I don't think it's strictly necessary, given that the issues identified are invalid. On the plus side it would eliminate the possibility of confusion (i.e. other IPMC members testing out the release and finding that the build fails).
Up to you. Update my vote to +0 rather than prior -1. Patrick On Mon, May 30, 2011 at 11:56 AM, Tom White <[email protected]> wrote: > Patrick, > > I've created a patch to fix the issues you found in WHIRR-319. Do you > think I should roll a new candidate with these changes? > > Thanks, > Tom > > On Fri, May 27, 2011 at 2:58 PM, Patrick Hunt <[email protected]> wrote: > > Hm, actually the two items it found are bogus: > > > > Unapproved licenses: > > src/site/confluence/whirr-in-5-minutes.confluence.rej > > src/site/resources/images/whirr-logo.ai > > > > but still, something is wrong that this wasn't flagged earlier in the > process. > > > > Patrick > > > > On Fri, May 27, 2011 at 2:52 PM, Patrick Hunt <[email protected]> > wrote: > >> -1 > >> > >> In general things look good (signature valid, tests pass), however RAT > >> is failing: > >> > >> from the rc1 source archive file: > >> whirr-0.5.0-incubating$ mvn apache-rat:check > >> ... > >> [ERROR] BUILD FAILURE > >> [INFO] > ------------------------------------------------------------------------ > >> [INFO] Too many unapproved licenses: 2 > >> .... > >> > >> any idea why RAT isn't running as part of the std build, or at least > >> as part of the release process? > >> > >> > >> I also notice that the two RC archives are unarchiving to the same > >> directory. Shouldn't the -src archive unarchive to a -src directory? > >> It would be confusing otherwise. > >> > >> Patrick > >> > >> On Thu, May 26, 2011 at 2:25 AM, Andrei Savu <[email protected]> > wrote: > >>> +1 > >>> > >>> * checked signatures and hashes for both archives > >>> * unit tests pass on source release and SVN tag > >>> * integration tests pass on aws-ec2 and cloudservers-us > >>> * started a HBase cluster and executed the ycsb_quick_test.sh script > >>> > >>> Cheers, > >>> > >>> -- Andrei Savu > >>> > >>> On Thu, May 26, 2011 at 7:48 AM, Tom White <[email protected]> > wrote: > >>>> Please vote on this second incubator release candidate for Apache > Whirr, > >>>> version 0.5.0-incubating. > >>>> > >>>> It fixes the following issues: > >>>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12316248&styleName=Html&projectId=12311110 > >>>> > >>>> Note that we are voting upon the source (tag), binaries are provided > >>>> for convenience. > >>>> > >>>> Source and binary files: > >>>> http://people.apache.org/~tomwhite/whirr-0.5.0-incubating-candidate-1 > >>>> > >>>> Maven staging repo: > >>>> https://repository.apache.org/content/repositories/orgapachewhirr-012 > >>>> > >>>> The tag to be voted upon: > >>>> > http://svn.apache.org/repos/asf/incubator/whirr/tags/release-0.5.0-incubating > >>>> > >>>> Whirr's KEYS file containing PGP keys we use to sign the release: > >>>> http://svn.apache.org/repos/asf/incubator/whirr/dist/KEYS > >>>> > >>>> The vote is open for 72 hours. > >>>> > >>>> Note that the Incubator PMC needs to vote upon the release after a > >>>> successful PPMC vote before any release can be made official. > >>>> > >>>> Thanks, > >>>> Tom > >>>> > >>> > >> > > >
