[
https://issues.apache.org/jira/browse/WHIRR-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044701#comment-13044701
]
Tom White commented on WHIRR-313:
---------------------------------
Generally looks good. Thanks for the contribution, Edward. Here are a few
comments I had after reading through the patch:
* It's important that the Hama library dependency has test scope, since Whirr
shouldn't have a dependency on any particular version - it's only used for the
integration test. This applies to hama-examples too.
* hama.version is defined in pom.xml, but not used.
* beforeBootstrap() can be pulled up into the abstract cluster handler.
> Add Hama as a Service
> ---------------------
>
> Key: WHIRR-313
> URL: https://issues.apache.org/jira/browse/WHIRR-313
> Project: Whirr
> Issue Type: New Feature
> Affects Versions: 0.4.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.6.0
>
> Attachments: HAMA.patch, WHIRR-313_v01.patch, WHIRR-313_v02.patch,
> WHIRR-313_v03.patch, WHIRR-313_v04.patch
>
>
> This issue adds Hama as a Service to Whirr.
> I just wrote some code today but haven't run the integration tests yet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
