[
https://issues.apache.org/jira/browse/WHIRR-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066917#comment-13066917
]
Bruno Dumon commented on WHIRR-339:
-----------------------------------
I created WHIRR-342 for the issue regarding configuration/role conflicts.
Meanwhile learned that the patch as-is will break the hbase testcases (because
of WHIRR-342), which run a thrift server on a separate node without
master/regionserver. The instance-templates in whirr-hbase-test.properties (for
both plain/cdh hbase) should be adjusted. The patches on WHIRR-240 & WHIRR-334
actually contain such a change already, so with those applied all should be ok.
Regarding hbase.client.retries.number: ok, interesting, we should include it
then.
> Allow to specify hbase-site.xml properties through cluster configuration file
> -----------------------------------------------------------------------------
>
> Key: WHIRR-339
> URL: https://issues.apache.org/jira/browse/WHIRR-339
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Reporter: Bruno Dumon
> Attachments: WHIRR-339.patch
>
>
> Currently the hbase-site.xml configuration is hardcoded in the
> configure(_cdh)_hbase.sh script. This patch adds dynamic generation of
> hbase-site.xml, modelled after what is done for
> hadoop-(common|mapred|hdfs)-site.xml.
> The user is able to specify custom properties in their cluster configuration,
> by prefixing them with 'hbase-site.'
> Default config is in whirr-hbase-default.properties. Compared to what was in
> configure_hbase.sh before, I dropped the setting of
> "hbase-site.hbase.client.retries.number=100" because I'm not sure we should
> divert from the HBase default there.
> I left in the passing of the ZOOKEEPER_QUORUM to the configure script, as I
> figured people using custom scripts might still want to have it (there's a
> PORT variable passed that doesn't seem to be used either).
> On a more general note, this patch has the same limitations as for Hadoop:
> running master and regionserver on same node will not work as the
> configuration will be appended twice to the same file, and running the
> restserver/thriftserver not together with regionserver or master will fail
> due to missing hbase-site.xml. Solving this is a topic of its own.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
