[ 
https://issues.apache.org/jira/browse/WHIRR-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086873#comment-13086873
 ] 

Karel Vervaeke commented on WHIRR-368:
--------------------------------------

I have done this for the hbase master and regionserver java options in this 
branch: https://github.com/karel1980/whirr/tree/hbase-env

Perhaps we should support arbitrary environment properties like this:

whirr.hbase-env.properties.FOO=bar
whirr.hadoop-env.properties.QUX=meta

I don't think we should pass each of these as options to the configure_hbase 
and configure_hadoop scripts.
Option one would be to generate the env.sh files locally and make them 
available via the blobcache.
Option two would be to implement a function, and set the properties via 
individual calls:

function set_env_var() {
  file="$1"
  name="$2"
  value="$3"

  # note: name and value should be escaped to avoid breakage
  sed -i -e "s|^export $name=|export $name=$value|" $file
}

I personally like the second one a little better, as it could be reused for 
different services.

> Add the ability to adjust contents of hadoop-env.sh from a cluster properties 
> file
> ----------------------------------------------------------------------------------
>
>                 Key: WHIRR-368
>                 URL: https://issues.apache.org/jira/browse/WHIRR-368
>             Project: Whirr
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.5.0
>            Reporter: Soren Macbeth
>
> I'd like to be able to adjust the values in the hadoop-env.sh via the 
> .properties in a way similar to how adjusting settings in the hadoop 
> configuration files is currently done. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to