[ 
http://issues.apache.org/jira/browse/WICKET-33?page=comments#action_12447144 ] 
            
Bernhard Frauendienst commented on WICKET-33:
---------------------------------------------

I agree with you, tests are vital when building packages from source. But there 
should be a possibility for "external" systems to steer the build flow (for 
example packaging systems on Linux distributions, which often have a test 
feature the user can enable or disable).

Your solution sounds like a good compromise between effectiveness and number of 
changes. It should just require an unless="maven.test.skip" in the test- and 
test-compile targets (have to be both, because unless doesn't effect 
dependencies, they get executed before the unless is evaluated).

> Ant jar target that doesn't depend on tests
> -------------------------------------------
>
>                 Key: WICKET-33
>                 URL: http://issues.apache.org/jira/browse/WICKET-33
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket
>    Affects Versions: 1.2.3
>            Reporter: Bernhard Frauendienst
>         Assigned To: Martijn Dashorst
>            Priority: Trivial
>
> I'd very much appreciate it, if the ant build file could get a jar target 
> that doesn't depend on junit tests (those should be voluntary).
> Possible solutions:
> 1) Change "jar"-target dependency from "test" to "compile" and introduce a 
> new "all"-target for both combined:
> 2) Keep the jar-target and create a new one that "skips" the tests (possible 
> name: "jar-notest")
> A patch snippet for solution one is attached below:
> @@ -114,9 +114,10 @@
>                         />
>         </target>
> -       <target name="jar" depends="test" description="o Creates a JAR file 
> for this package">
> +       <target name="jar" depends="compile" description="o Creates a JAR 
> file for this package">
>                 <jar jarfile="${final.name}.jar"
>                         excludes="**/package.html"
>                         basedir="${build.main.classes}"/>
>         </target>
> +       <target name="all" depends="test,jar" description="o Runs the unit 
> tests and creates a JAR file for this package"/>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to