[ http://issues.apache.org/jira/browse/WICKET-102?page=comments#action_12452306 ] Eelco Hillenius commented on WICKET-102: ----------------------------------------
I don't really see a big advantage to that. People can override getDateFormat(Locale) themselves if they want, which gives them all the flexibility they'll ever need. Keeping formats is just more bloat. > potential concurrency problem with DateConverter > ------------------------------------------------ > > Key: WICKET-102 > URL: http://issues.apache.org/jira/browse/WICKET-102 > Project: Wicket > Issue Type: Bug > Affects Versions: 1.3, 2.0 > Reporter: Eelco Hillenius > Fix For: 1.3, 2.0 > > > DateConverter uses a 'cache' (HashMap) with DateFormats. The problem (don't > ask me why I never noticed) is that SimpleDateFormats are not thread safe. > Never were, never will be (see > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4264153 and > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4228335) > The solution is the remove setDateFormat (which is probably never used by > anyone anyway), and always return new instances. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
