[ http://issues.apache.org/jira/browse/WICKET-128?page=all ]

Johan Compagner reassigned WICKET-128:
--------------------------------------

    Assignee: Eelco Hillenius

yeah this is strange.
We can move it to Session.seAttribute but then it should be completely copied 
from HttpSessionStore:

// Do some extra profiling/ debugging. This can be a great help
                // just for testing whether your webbapp will behave when using
                // session replication
                if 
(Application.get().getDebugSettings().getSerializeSessionAttributes())
                {
                        if (value instanceof Page)
                        {
                                ((Page)value).internalDetach();
                        }
                        String valueTypeName = (value != null ? 
value.getClass().getName() : "null");
                        try
                        {
                                final ByteArrayOutputStream out = new 
ByteArrayOutputStream();
                                new ObjectOutputStream(out).writeObject(value);
                                log.debug("Stored attribute " + name + "{ " + 
valueTypeName + "} with size: "
                                                + Bytes.bytes(out.size()));
                        }
                        catch (Exception e)
                        {
                                throw new WicketRuntimeException(
                                                "Internal error cloning object. 
Make sure all dependent objects implement Serializable. Class: "
                                                                + 
valueTypeName, e);
                        }
                }

and removed in the store.


> Debug settings / serialize session attributes option not working
> ----------------------------------------------------------------
>
>                 Key: WICKET-128
>                 URL: http://issues.apache.org/jira/browse/WICKET-128
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 2.0
>            Reporter: Martin Benda
>         Assigned To: Eelco Hillenius
>
> Session attributes are serialized even if this debug setting is turned off. 
> I've noticed that the code that serializes attributes and logs their 
> serialized size in HttpSessionStore#setAttribute is duplicated in 
> Session#setAttribute - but without the debug settings condition. This code 
> was added by the recent patch resolving WICKET-100 and only in the trunk, not 
> in the wicket-1.x branch... why???
> Regards,
> Bendis

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to