[ 
http://issues.apache.org/jira/browse/WICKET-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461659
 ] 

Nathan Hamblen commented on WICKET-149:
---------------------------------------

Yes, I applied that change to my tree when it came in but I had to reapply my 
own patch to get things working again. The first time I came up with these 
patches I did a lot of tracing to see exactly what was necessary, and the 
condition that you are checking there (I think it's if the path matches '/' 
exactly) is not sufficient. getPath() is expected to always return with a 
leading slash, but the method in the tree does not do that.

I wonder if you've tested it only with a root mounted servlet context? The ones 
that I'm using have context paths.

> mounted URLs fail if filterPath is blank
> ----------------------------------------
>
>                 Key: WICKET-149
>                 URL: http://issues.apache.org/jira/browse/WICKET-149
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3
>         Environment: jetty 5/6
>            Reporter: Nathan Hamblen
>         Assigned To: Alastair Maw
>             Fix For: 1.3
>
>         Attachments: slashCheck.diff
>
>
> The path in RequestParameters needs to begin with a "/" or it will not be 
> found when checking against mounted paths. The slash is prefixed in 
> WicketFilter line 545 when checking isWicketRequest(), but it is not prefixed 
> later when looking for the request target. Proposed fix in patch (to be 
> attached) performs this operation in ServletWebRequest.getPath(); I'm not 
> sure if that is the ideal spot, but I've confirmed that it fixes the problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to