[ 
https://issues.apache.org/jira/browse/WICKET-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469234
 ] 

Igor Vaynberg commented on WICKET-4:
------------------------------------

no that would be horrible. besides we already have attach()/detach() that 
encapsulate the super-called check.

maybe all we do is this

mark onattach as final and tell people to move to onbeginrender

let that break sit in there for a few weeks to give people a chance to migrate, 
then go back in and rework onattach

> Page.onBeginRequest() [and consequently .onAttach()] not called when form on 
> page is submitted.
> -----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4
>                 URL: https://issues.apache.org/jira/browse/WICKET-4
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.2.2
>         Environment: os = OS X 10.4.8; java version = jre/jdk 1.5.0_06; 
> servlet container =  jetty-5.1.11RC0
>            Reporter: Paul Milovanov
>         Assigned To: Johan Compagner
>            Priority: Critical
>             Fix For: 1.3, 2.0
>
>
> Page.onBeginRequest() [and consequently .onAttach()] not called when form on 
> page is submitted. Form.onBeginRequest() is not called as well. However, 
> Page.onEndRequest()  and Form.onEndRequest() are called correctly.
> In more detail: 
> I have a page, FrontPage, and a form LoginForm on it (The form has 
> defaultFormProcessing = true)
> onBeginRequest(), onEndRequest() in FrontPage, LoginForm, are overriden as 
> follows:
>       protected void onBeginRequest() {
>               log.debug("request begin");
>               ...
>               super.onBeginRequest();
>       }
>       protected void onEndRequest() {
>               super.onEndRequest();
>               ...
>               log.debug("request end");
>       }
> So I load FrontPage, type in data into the form (that corr. to LoginForm) and 
> submit form.
> The log output is as follows
> //first load of page
> DEBUG <hotline.pages.FrontPage> request begin
> ...
> DEBUG <hotline.pages.FrontPage$LoginForm> request begin
> ...
> DEBUG <hotline.pages.FrontPage> request end 
> DEBUG <hotline.pages.FrontPage$LoginForm> request end
> ...
> //form submitted
> DEBUG <hotline.pages.FrontPage> request end
> DEBUG <hotline.pages.FrontPage$LoginForm> request end

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to