[ 
https://issues.apache.org/jira/browse/WICKET-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490333
 ] 

Johan Compagner commented on WICKET-476:
----------------------------------------

i think that is a bit dangerous. IF (and then it is bug that getSession is 
there purely to see if the bug is still there somehow...) but if getSession() 
is still wrong
and we throw there an exception but that pagemap is somehow already in the http 
session then we have a problem. Because that session is then completely not 
useable anymore (the exception will happen everytime) 
So the only real other option is session.invalidate()...

> Backport RequestCycle#updateSession and pagemap#session removal to 1.2.x
> ------------------------------------------------------------------------
>
>                 Key: WICKET-476
>                 URL: https://issues.apache.org/jira/browse/WICKET-476
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.2.5
>            Reporter: Martijn Dashorst
>         Assigned To: Johan Compagner
>             Fix For: 1.2.6
>
>
> A cleanup bug in the requestcycle may leave dirty objects in the dirtyObjects 
> threadlocal. Removing RequestCycle.updateSession and pagemap#session as we 
> did in 1.3 solves this particular problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to