Author: ehillenius
Date: Tue Apr 24 17:20:17 2007
New Revision: 532153

URL: http://svn.apache.org/viewvc?view=rev&rev=532153
Log:
delete in a batch as that is cheaper for a copy on write list

Modified:
    
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/feedback/FeedbackMessages.java

Modified: 
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/feedback/FeedbackMessages.java
URL: 
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/feedback/FeedbackMessages.java?view=diff&rev=532153&r1=532152&r2=532153
==============================================================================
--- 
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/feedback/FeedbackMessages.java
 (original)
+++ 
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/feedback/FeedbackMessages.java
 Tue Apr 24 17:20:17 2007
@@ -97,16 +97,9 @@
                        return 0;
                }
 
-               int count = 0;
-               for (final Iterator iterator = messages.iterator(); 
iterator.hasNext();)
-               {
-                       final FeedbackMessage message = 
(FeedbackMessage)iterator.next();
-                       if (filter == null || filter.accept(message))
-                       {
-                               messages.remove(message);
-                               count++;
-                       }
-               }
+               List toDelete = messages(filter);
+               int count = toDelete.size();
+               messages.removeAll(toDelete);
 
                trimToSize();
                return count;


Reply via email to