[
https://issues.apache.org/jira/browse/WICKET-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500158
]
Kurt Roekle commented on WICKET-579:
------------------------------------
If the estimated size is less then the actually size, then DataTable will not
display the "extra rows" (DataTable only requests from the iterator method up
to what's returned from the size method). And if the estimated size is greater
then the actual size, you get extra blank pages (which DataTable handles ok).
It also doesn't address the performance concerns, it could be just as costly to
come up with an estimate then with an actual size.
> Need for DataTable not to require size
> --------------------------------------
>
> Key: WICKET-579
> URL: https://issues.apache.org/jira/browse/WICKET-579
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-beta1
> Environment: 1.3 snapshot dated 4/25
> Reporter: Kurt Roekle
> Attachments: wicket-toolbar.jar
>
>
> Requiring a size query for the DataProvider passed to the DataTable hurts
> performance and scalability (not to mention, it wont be accurate in a system
> when a lot of updates/deletes are taking place). I had hoped to be able to
> code just a new toolbar and DataProvider that would fix this, but I found I
> needed changes in DataTable and AbstractPageableView due to the fact
> AbstractPageableView caches the row count. I've made fixes for DataTable and
> AbstractPageableView and I've included one new interface that would be
> required. I've also added an implementation of a new toolbar and
> DataProvider that will enable DataTable to work without size (I've also
> included a modified NavigationToolbar (and friends) that could be implemented
> instead of a new toolbar. I've tested these changes with my limited
> knowledge of wicket and they seem to not break any existing code. I
> currently can't give you a diff, but the line #'s that changed are as follows:
>
> AbstractPageableView: 70,97,137,139,142-149
> DataTable: 120-122
> NavigationToolbar: 39,49,60,64,88,104
> PagingNavigator: 48,62-66,81,97,110
> NavigatorLabel: 42,54,74
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
