[ 
https://issues.apache.org/jira/browse/WICKET-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503966
 ] 

Eelco Hillenius commented on WICKET-605:
----------------------------------------

I saw the usual heroic remarks (wtf!, retarded!) on the IRC log about the fact 
that PageParameters sets itself as the parameters object in the request cycle.

If you would actually follow that code a bit, you can see that it only sets 
itself when the request is still resolving; after that the parameter just won't 
be set so you can construct the page parameters object while handling events 
and rendering etc as much as you like. Solving it like this looked better to me 
than doing it the request cycle processing itself, as that would be exactly the 
kind of code-duplication introducing fix people have been complaining about 
lately. 

This is the idea, and I hope I didn't overlook something (mind you I did ask 
for a review). If anyone has a better solution, please contribute.

> Stateless form skips page parameters
> ------------------------------------
>
>                 Key: WICKET-605
>                 URL: https://issues.apache.org/jira/browse/WICKET-605
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta1
>         Environment: linux, glassfish v2
>            Reporter: József Börcsök
>            Assignee: Johan Compagner
>             Fix For: 1.3.0-beta2
>
>
> Page parameters are not included in stataless form action parameter.
> I think stateless form should override urlFor(RequestListenerInterface 
> listener) method and append page parameters. (Submit works if I manually add 
> them at runtime ie. with firebug plugin in browser.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to