[ 
https://issues.apache.org/jira/browse/WICKET-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511683
 ] 

Alastair Maw commented on WICKET-741:
-------------------------------------

Fixed in r555197.

> Double quotes aren't escaped properly in component tag attributes.
> ------------------------------------------------------------------
>
>                 Key: WICKET-741
>                 URL: https://issues.apache.org/jira/browse/WICKET-741
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.3.0-beta2
>            Reporter: Alastair Maw
>            Assignee: Alastair Maw
>            Priority: Minor
>             Fix For: 1.3.0-beta3
>
>
> See 
> http://www.nabble.com/Escaping-quotes-in-attributes-tf4044002.html#a11487305.
> Why is ComponentTag escaping quotes in attribute values with a backslash?
> For valid xhtml it should be an entity:
> Index: 
> /home/sven/workspace/wicket/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/ComponentTag.java
> ===================================================================
> --- 
> /home/sven/workspace/wicket/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/ComponentTag.java
>    (revision 554069)
> +++ 
> /home/sven/workspace/wicket/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/ComponentTag.java
>    (working copy)
> @@ -653,7 +653,7 @@
>                     if (value != null)
>                     {
>                         response.write("=\"");
> -                        value = Strings.replaceAll(value, "\"", "\\\"");
> +                        value = Strings.replaceAll(value, "\"", """);
>                         response.write(value);
>                         response.write("\"");
>                     }
> Should it not?
> Sven 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to