Eelco Hillenius wrote:
On 10/19/06, Jean-Baptiste Quenot <[EMAIL PROTECTED]> wrote:
Hi,
I need an ajax submit button that does not validate the form.
Therefore I noticed in trunk the new IFormSubmittingComponent that
works with Button, SubmitLink and AjaxSubmitButton.
I backported that feature to branch wicket 1.x, but I need your
advice prior to filing the patch in Jira, as the visibility of
method onSubmit() has changed from protected to public, which may
cause backwards compatibility problem.
That should not cause any real backwards compat problems, right?
It would, actually. If you change method signature from protected to
public, most of your code wont even compile, as all the implementation
are protected, which would reduce visibility.
-Matej
If compatibility is an issue for branch 1.x, I propose to backport
the feature without using the interface IFormSubmittingComponent,
but using Button. Indeed SubmitLink and AjaxSubmitButton both
extend Button, so using the interface is not mandatory.
Could you please open a feature request for this at
http://issues.apache.org/jira/browse/WICKET ? Many of us are a bit
tied up lately, so that's the best way to keep it in the attention
zone.
Cheers,
Eelco
