I hate that I have to call setRequired on form components, yet I don't
introduce RequirecDropDownChoice, and vote to remove RequiredTextField
probably same for: Component.setResponsePage() vs.
RequestCycle.get().setResponsePage()
It is bloating our api, and doesn't give anything extra you can't
already achieve by creating your own, custom component that does
exactly as you wish. And Wicket is advocating creating custom
components.
BTW How often do you *really* have to add the label to the link? Only
once in a menu panel? How often do you just have some text in the
markup?
What is the benefit of doing so if you can just add a <wicket:message>
in the markup?
We use links on and around all kinds of stuff, including: <tr>, <td>,
<div> <span> <img> etc.
Laziness is a bad motivator for expanding an api as has been said time
and time again on these mailinglists
Martijn
On 10/25/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
Well, what we're not proposing here is a solution that works in 100%
of the cases. Btw, it would work fine for localization; you just need
to get the localizer directly.
But like I stated, my main reasons for being pro this:
* We get questions like this all the time. In this case Korbinian was
aware of that you could nest labels/ create a custom component, but
just thought - like I believe the other people that brought this
forward in the past - this isn't a great default.
* I'm regularly tired of having to nest a label all the time. It's a
(slight) waste of memory to do that, and even though I know I can
create a custom component to do that, in the end I never do.
Eelco
On 10/25/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote:
> and then:
>
> <a href="#" wicket:id="link"><wicket:message ...></a>
>
> makes a lot more sense.
>
> And in your previous case: it doesn't clutter... it makes it EXPLICIT
> what is happening, not implicit, no magic.
>
> Martijn
>
> On 10/25/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote:
> > But we have to take internationalization into account... Just having a
> > string label is not sufficient.
> >
> > Martijn
> >
> > On 10/25/06, Johan Compagner <[EMAIL PROTECTED]> wrote:
> > > i already said this from wicket day 1.
> > > I still don't like that you have to do this:
> > >
> > > <a href="#" wicket:id="link"><span wicket:id="label"></span></a>
> > >
> > > i really don't like that. It clutters markup with the span and you have to
> > > make 2 components in wicket
> > > And i think that the label part is a text property of the anchor. It is
not
> > > standalone.
> > > (see it as the display value of the action value == the href)
> > >
> > > maybe how FormComponents work:
> > >
> > > public IModel getLabel()
> > > {
> > > return this.labelModel;
> > > }
> > >
> > > but we could say, don't make another member variable to reduce the state,
> > > then a String getLabel() would be fine.
> > >
> > > And one method doesnt really clutter api, maybe a nice thing would be then
> > > you could
> > > set the label model through the constructor (just like formcomponent
should
> > > do.... but thats just to much work)
> > > so that it is really visible...
> > >
> > > johan
> > >
> > >
> > >
> > > On 10/25/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> > > >
> > > > On 10/25/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote:
> > > > > Still don't like it. It adds yet another way to work with links, and
> > > > > requires subclassing to do so. What is more convenient?
> > > > >
> > > > > new Label(new BookmarkablePageLink(this, "link"), "label", "Text");
> > > > >
> > > > > or
> > > > >
> > > > > new BookmarkablePageLink(this, "link") {
> > > > > protected String getLabel() {
> > > > > return "Text";
> > > > > }
> > > > > };
> > > >
> > > > I would find the latter more convenient as there is no label in the
> > > > markup, and it's also more efficient as it saves having an extra
> > > > component for each link.
> > > >
> > > > Eelco
> > > >
> > >
> > >
> >
> >
> > --
> > <a href="http://www.thebeststuffintheworld.com/vote_for/wicket";>Vote</a>
> > for <a href="http://www.thebeststuffintheworld.com/stuff/wicket";>Wicket</a>
> > at the <a href="http://www.thebeststuffintheworld.com/";>Best Stuff in
> > the World!</a>
> >
>
>
> --
> <a href="http://www.thebeststuffintheworld.com/vote_for/wicket";>Vote</a>
> for <a href="http://www.thebeststuffintheworld.com/stuff/wicket";>Wicket</a>
> at the <a href="http://www.thebeststuffintheworld.com/";>Best Stuff in
> the World!</a>
>
--
<a href="http://www.thebeststuffintheworld.com/vote_for/wicket";>Vote</a>
for <a href="http://www.thebeststuffintheworld.com/stuff/wicket";>Wicket</a>
at the <a href="http://www.thebeststuffintheworld.com/";>Best Stuff in
the World!</a>
