Re: Reopen WICKET-95 Backport of Header contribution filtering to 1.x?

[Matej Knopp]

I believe that patch wasn't meant to be applied against 1.2.3. It's 
should be applied against 1.x (1.3), which I believe it already was.

Making StringResponse serializable is not a good idea IMHO, as the 
problem is somewhere else. The response classes should never be stored 
in session.

-Matej

Jean-Baptiste Quenot wrote:
Hi,

I applied the patch located in the issue WICKET-95 to Wicket 1.2.3
with success.  But then when starting the webapp I had this error
on my SignIn page in DEVELOPMENT mode:

        NotSerializableException: wicket.response.StringResponse

Applying the attached patch against wicket-1.x fixes the problem.


------------------------------------------------------------------------

Index: src/main/java/wicket/response/StringResponse.java
===================================================================
--- src/main/java/wicket/response/StringResponse.java   (revision 477098)
+++ src/main/java/wicket/response/StringResponse.java   (working copy)
@@ -17,6 +17,7 @@
 package wicket.response;
 
 import java.io.OutputStream;
+import java.io.Serializable;
 
 import wicket.Response;
 import wicket.util.string.AppendingStringBuffer;
@@ -28,7 +29,7 @@
  * 
  * @author Jonathan Locke
  */
-public class StringResponse extends Response
+public class StringResponse extends Response implements Serializable
 {
        /** StringWriter to write to */
        protected final AppendingStringBuffer out;