but that repeater move is currently being done by igor. (as far as i know)
So then it will change anyway.
And if we move that i am +1 to do it in both places 1.3 and 2.0 to keep it
in sync as much as possible,
johan
On 12/9/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote:
Though not as popular as IModel, I think this will cause some
headache's with our users.
I suspect the most common use of IDataProvider is to do "new
IDataProvider(){...}" on the spot, though I am not sure.
I think this change is controversial enough to warrant a vote before
it is committed: we change a (semi) core interface to require a new
method.
When we move the repeaters up til DataView to core, IDataProvider also
needs a new home. If we rename the package to
wicket.markup.html.repeaters from
wicket.extensions.markup.html.repeaters that will also break the API.
If this were a controversial rename (we haven't decided, nor proposed
such a change yet, I know), then adding IDetachable to the
IDataProvider interface can also be considered controversial.
I'd rather see this change become part of revamping, and moving the
repeaters into core. Because if we decide to rename the packages, then
breaking the API is a lot less controversial than it is now.
Martijn
On 12/9/06, Johan Compagner <[EMAIL PROTECTED]> wrote:
> as i said it syncs the 2 api's 2.0 and 1.3 so thats a plus for me.
> And the api break is not that big, just one method that must be added
If
> that was not already done
> because you could already implemented IDetachable.
>
> johan
>
>
> On 12/9/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote:
> >
> > Hmm,
> >
> > Is this change discussed enough? This will break the API for a lot of
> > applications that use IDataProvider.
> >
> > Martijn
> >
> > On 12/9/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> > > Author: jcompagner
> > > Date: Sat Dec 9 01:57:53 2006
> > > New Revision: 484958
> > >
> > > URL: http://svn.apache.org/viewvc?view=rev&rev=484958
> > > Log:
> > > IDataProvider extends IDetachable
> > >
> > > Modified:
> > > incubator/wicket/branches/wicket-1.x
> >
/wicket-extensions/src/main/java/wicket/extensions/markup/html/repeater/data/IDataProvider.java
> > > incubator/wicket/branches/wicket-1.x
> >
/wicket-extensions/src/main/java/wicket/extensions/markup/html/repeater/data/ListDataProvider.java
> > > incubator/wicket/branches/wicket-1.x
> >
/wicket-extensions/src/main/java/wicket/extensions/markup/html/repeater/util/EmptyDataProvider.java
> > >
> > > Modified: incubator/wicket/branches/wicket-1.x
> >
/wicket-extensions/src/main/java/wicket/extensions/markup/html/repeater/data/IDataProvider.java
> > > URL:
> >
http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket-extensions/src/main/java/wicket/extensions/markup/html/repeater/data/IDataProvider.java?view=diff&rev=484958&r1=484957&r2=484958
> > >
> >
==============================================================================
> > > --- incubator/wicket/branches/wicket-1.x
/wicket-extensions/src/main/java/wicket/extensions/markup/html/repeater/data/IDataProvider.java
> > (original)
> > > +++ incubator/wicket/branches/wicket-1.x
/wicket-extensions/src/main/java/wicket/extensions/markup/html/repeater/data/IDataProvider.java
> > Sat Dec 9 01:57:53 2006
> > > @@ -16,7 +16,6 @@
> > > */
> > > package wicket.extensions.markup.html.repeater.data;
> > >
> > > -import java.io.Serializable;
> > > import java.util.Iterator;
> > >
> > > import wicket.model.IDetachable;
> > > @@ -24,12 +23,7 @@
> > >
> > > /**
> > > * Interface used to provide data to data views.
> > > - * <p>
> > > - * Note that if the IDataProvider implementation implements [EMAIL
PROTECTED]
> > IDetachable}
> > > - * interface, the [EMAIL PROTECTED] IDetachable#detach()} method will be
called at
> > the end
> > > - * of request.
> > > *
> > > - * <p>
> > > * Example:
> > > *
> > > * <pre>
> > > @@ -49,16 +43,20 @@
> > > * }
> > > * </pre>
> > > *
> > > + * You can use the [EMAIL PROTECTED] IDetachable#detach()} method for
cleaning
up
> > your
> > > + * IDataProvider instance. So that you can do one query that
returns
> > both
> > > + * the size and the values if your dataset is small enough the be
able
> > to
> > > + * do that.
> > > + *
> > > + * @see IDetachable
> > > * @see DataViewBase
> > > * @see DataView
> > > * @see GridView
> > > *
> > > * @author Igor Vaynberg (ivaynberg)
> > > *
> > > - * TODO 2.0: directly extend [EMAIL PROTECTED] IDetachable}
> > > - *
> > > */
> > > -public interface IDataProvider extends Serializable
> > > +public interface IDataProvider extends IDetachable
> > > {
> > > /**
> > > * Gets an iterator for the subset of total data
> > >
> > > Modified: incubator/wicket/branches/wicket-1.x
> >
/wicket-extensions/src/main/java/wicket/extensions/markup/html/repeater/data/ListDataProvider.java
> > > URL:
> >
http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket-extensions/src/main/java/wicket/extensions/markup/html/repeater/data/ListDataProvider.java?view=diff&rev=484958&r1=484957&r2=484958
> > >
> >
==============================================================================
> > > --- incubator/wicket/branches/wicket-1.x
/wicket-extensions/src/main/java/wicket/extensions/markup/html/repeater/data/ListDataProvider.java
> > (original)
> > > +++ incubator/wicket/branches/wicket-1.x
/wicket-extensions/src/main/java/wicket/extensions/markup/html/repeater/data/ListDataProvider.java
> > Sat Dec 9 01:57:53 2006
> > > @@ -77,4 +77,11 @@
> > > return new Model((Serializable)object);
> > > }
> > >
> > > + /**
> > > + * @see wicket.model.IDetachable#detach()
> > > + */
> > > + public void detach()
> > > + {
> > > + }
> > > +
> > > }
> > >
> > > Modified: incubator/wicket/branches/wicket-1.x
> >
/wicket-extensions/src/main/java/wicket/extensions/markup/html/repeater/util/EmptyDataProvider.java
> > > URL:
> >
http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket-extensions/src/main/java/wicket/extensions/markup/html/repeater/util/EmptyDataProvider.java?view=diff&rev=484958&r1=484957&r2=484958
> > >
> >
==============================================================================
> > > --- incubator/wicket/branches/wicket-1.x
/wicket-extensions/src/main/java/wicket/extensions/markup/html/repeater/util/EmptyDataProvider.java
> > (original)
> > > +++ incubator/wicket/branches/wicket-1.x
/wicket-extensions/src/main/java/wicket/extensions/markup/html/repeater/util/EmptyDataProvider.java
> > Sat Dec 9 01:57:53 2006
> > > @@ -65,4 +65,11 @@
> > > {
> > > return null;
> > > }
> > > +
> > > + /**
> > > + * @see wicket.model.IDetachable#detach()
> > > + */
> > > + public void detach()
> > > + {
> > > + }
> > > }
> > >
> > >
> > >
> >
> >
> > --
> > Vote for Wicket at the
> > http://www.thebeststuffintheworld.com/vote_for/wicket
> > Wicket 1.2.3 is as easy as 1-2-3. Download Wicket now!
> > http://wicketframework.org
> >
>
>
--
Vote for Wicket at the
http://www.thebeststuffintheworld.com/vote_for/wicket
Wicket 1.2.3 is as easy as 1-2-3. Download Wicket now!
http://wicketframework.org
