On 2/5/07, Frank Bille <[EMAIL PROTECTED]> wrote:
On 2/5/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
>
> Martijn/ Frank, I think I got all the headers, notices and patch to
> wicket-parent done ok and testing building the whole bunch. But if one
> of you could double check please...
>

* You have included the license header test but not executed it? There is
quite a few missing license headers.

Duh! I ran maven but with tests off. Anyway, I don't think I actually
missed headers, but there are a couple of inclusions from Yahoo. So do
I just instantiate the appropriate arrays (like cssIgnore) to mark
these Yahoo files to be ignored?

* assembly should be under src ;o)

Nice. Don't know how that ended up there.

I'm actually wondering if we need that licenses dir at all? They should only
be needed in core where they are actually used. WDYT?

I'll remove them with pleasure.

Eelco

Reply via email to