Talking about bugs and referring to the thread http://www.nabble.com/refactor-storing-pages-and-versions-tf2943670.html#a8231263: We are probably one of the few who did overwrite the UndoPageVersionManager, and the reason is a bug in that implementation:
* each time beginVersion is called, the versionNumber is incremented and a new changeList is created. But that new changeList is NOT added to the stack of changeLists. * when getVersion(int versionNumber) is called with an older versionNumber after a call to beginVersion() and before a call to endVersion(), the undo() method is called, which pops the last changeList from the stack and decrements the versionNumber. Since the 'current' changeList is not yet on the stack, it pops one more changeList from the stack than it should. Something to be corrected ? Mayby the newly created changeList should be added to the stack immediately ? Or is it more correct to not increment the versionNumber until the call to endVersion() ? Jan. Eelco Hillenius wrote: > >> if there are problems with 2.0 supporting this then they should be >> addressed, feel free to open jira issues. > > It's in 1.3 too (and yes, in fact it *is* potentially problematic for > the app we're working on as well). And there is JIRA issue > http://issues.apache.org/jira/browse/WICKET-201 (which refers to > http://www.nabble.com/refactor-storing-pages-and-versions-tf2943670.html#a8231263). > > Eelco > > -- View this message in context: http://www.nabble.com/Single-page-applications%3A-bad-idea-in-Wicket---tf3182341.html#a8832724 Sent from the Wicket - Dev mailing list archive at Nabble.com.
