On 2/25/07, Jonathan Locke <[EMAIL PROTECTED]> wrote:
i don't want to gang up on martijn here, but that's what i meant. i also think we should refactor pagelink with the remaining two constructors to: pageclasslink (the one with the class contructor)
What's the advantage of have the class one anyway actually? As far as I can see, such use is only possible with pages with public default constructors or constructors with a page parameters argument - in other words, bookmarkable pages. This link would then create an internal link, which has no advantage in this case over bookmarkable links; it forces pages to be kept in the page map, even if they are stateless (and also forces session creation as a result of that). And I don't think many if any people are using exotic versions of IPageFactory to create non-bookmarkable page instances based on the class argument.
delayedpagelink (the one with the ipagelink constructor)
I like the name PageLink much better tbh. If PageLink would only have the IPageLink parameter, it's usage is obvious and I think PageLink is an easier to discover name than DelayedPageLink. My 2c, Eelco
