Hi,

first why is in the current head (of 1.3)

   public void renderOnDomReadyJavascript(String javascript)
and
   public void renderOnLoadJavascript(String javascript)

not tested for if that script is already rendered?
(For both the HeaderResponse and the AjaxHeaderResponse)

all others are. (so i made that now also the case for the HR and AHR)

But why do we override those 2 methods in the AHR and not the method:

public void renderJavascript(CharSequence javascript, String id)

so that we also can add them tho the appendJavascripts list? (just as we do
with onLoad and onDom)

If we do that then we could also sync the appendJavaScript method of
AjaxRequestTArget with
the 3 (onDom,onLoad and just javascript) to test for duplicates.

Because what is really different of all the append javascript methods of ART
and render method of HR?

For example why do we have an extra ID in the HR of renderJavaScript (to
target duplicates or to say it is for this X thing)
but we don't have that in the ART append methods..

Couldn't for exampel ART be a HR (instead of having an inner class AHR?)
It is sort of the same isn't it?

johan

Reply via email to