Jean-Baptiste Quenot wrote:
I noticed a few things.
README.txt
Shall we replace wicket-library.com with wicketstuff.org?
This seems like a preference, not a requirement.
NOTICE.txt
Every NOTICE.txt file has duplicates:
jdk-1.4/wicket/NOTICE.txt
jdk-1.4/wicket/target/classes/META-INF/NOTICE.txt
jdk-1.4/wicket-datetime/NOTICE.txt
jdk-1.4/wicket-datetime/target/classes/META-INF/NOTICE.txt
This is surely so that NOTICE files go into jar files.
NOTICE.txt again
Mention that CreditCardValidator, WildcardMatcherHelper comes from
Apache Cocoon maybe.
The code is ASL licensed so there's no major problem here. It would be
polite to mention they came from Apache Cocoon, and should be done for
future releases. I think this release can proceed without it.
<snip/>
Unless there is something wrong on my side, I vote -1 so that we
can fix this blocker JMX loading problem at least.
The rest are technical in nature and are thus irrelevant for the purpose
of this vote.
Do you still keep to your -1 vote?
Note, I'm not to concerned about having an iteration or two with the
IPMC. It isn't a major issue to show them a release, deal with some
issues and roll another (apart from the time taken).
Rather than reject this release and roll another, we should get this
release in front of the IPMC now. Then when we roll our next, we can
deal with these issues and any others the IPMC raises all in one go.
Less work all round.
Regards, Upayavira
