It shouldn't because then all over the place you should take care of it. So convertToString should convert it always to a real string object null == "" and "" stays ""
because the outputstream.print(null) outputs "null" jhan On 4/4/07, Jean-Baptiste Quenot <[EMAIL PROTECTED]> wrote:
* [EMAIL PROTECTED]: > Author: jcompagner > Date: Mon Apr 2 06:04:09 2007 > New Revision: 524778 > > URL: http://svn.apache.org/viewvc?view=rev&rev=524778 > Log: > default null or "" should return "" when converting object to string > (because that is displayed in the browser and the visual string shouldnt be 'null' but '' > > > Modified: > incubator/wicket/branches/wicket-1.x/jdk-1.4 /wicket/src/main/java/wicket/util/convert/ConverterLocator.java > > Modified: incubator/wicket/branches/wicket-1.x/jdk-1.4 /wicket/src/main/java/wicket/util/convert/ConverterLocator.java > URL: http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/wicket/util/convert/ConverterLocator.java?view=diff&rev=524778&r1=524777&r2=524778 > ============================================================================== > --- incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/wicket/util/convert/ConverterLocator.java (original) > +++ incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/wicket/util/convert/ConverterLocator.java Mon Apr 2 06:04:09 2007 > @@ -132,7 +132,7 @@ > { > if (value == null || "".equals(value)) > { > - return null; > + return ""; > } > > return (String)Objects.convertValue(value, String.class); > > Hello Johan, We need to define urgently the clear contract of IConverter#convertToString(), whether it can return null values or not. If it can, caller should ensure to handle the null value explicitly. Currently the Javadoc does not state this clearly: /** * Converts the given value to a string. * * @param value * The value to convert * @param locale * TODO * * @return The converted string value */ String convertToString(Object value, Locale locale); WDYT? -- Jean-Baptiste Quenot aka John Banana Qwerty http://caraldi.com/jbq/
