this shouldve been the commit message and then everyone wouldve been happy.
thank you -igor On 4/13/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
http://cwiki.apache.org/WICKET/migrate-13.html#Migrate-1.3-RequestCycle%252CIRequestCycleFactory%252CSession%252CIPageMapandPageMapchanges > > helps. > > this says what, but not the why. Ok, I thought it was obvious from just looking at the changes, but here we go. * We got rid of getDefaultRequestCycleFactory and replaced it by getRequestCycleFactory in Application, and we don't create the request cycle through the session anymore. That's what but if you pull out your API elegance tentacles, it's the why as well. * We only create a session instance when we really need to (it's created lazily). Possibly a slight optimization. The creation and registering of the session is all in the right place now. Not scattered througout wicket filter and application, but just in the session itself. * The request cycle is now available in the Session's constructor. I believe this was what Jonathan needed for better testing support, but I'm not sure. * PageMaps were updated for the session on every request, and held a reference to the session object. This wasn't needed at all, so this is a cleanup and efficiency improvement. Eelco
