Actually, tbh, I think it's kind of ugly we Buttons and SubmitLinks as separate entities. Imo, a really good solution would be to just have Button, that works on anything Button and SubmitLink work on now.
Eelco On 5/2/07, Jean-Baptiste Quenot <[EMAIL PROTECTED]> wrote:
* [EMAIL PROTECTED]: > Author: jcompagner > Date: Tue May 1 02:37:59 2007 > New Revision: 533985 > > URL: http://svn.apache.org/viewvc?view=rev&rev=533985 > Log: > we really can't just terminate <button tag for the Button component! (it did break all our solutions!) > i now only output the value string if it is a <input > what about the name attribute can that be always included? > > Modified: > incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/Button.java > > protected void onComponentTag(final ComponentTag tag) > { > - checkComponentTag(tag, "input"); > - > // Default handling for component tag > super.onComponentTag(tag); Hi Johan, I changed the code to enforce the use of <input> because Button does not work with <button>, confirmed by Igor on IRC. If you really want a <button> you should use a Link instead. Or if you really want Button, use <input> instead. Currently it's not obvious for users that Button does not handle <button>, so please update your code so that we can bring back the <input> tag check. Cheers, -- Jean-Baptiste Quenot aka John Banana Qwerty http://caraldi.com/jbq/
