i'm no committer, but i'm -1 for this change. just my 2 cents.
i'd much rather use constructor arguments to ensure correct
construction than overriding methods.
On 5/7/07, Jean-Baptiste Quenot <[EMAIL PROTECTED]> wrote:
Hi team,
Thanks for adding wicket-velocity. One suggestion though, can we
make VelocityPanel abstract to let the user return the
IStringResourceStream instead of passing it in the constructor?
That would be nicer.
That would also allow to simplify the example, currently building
the template inline with StringBuffer.
This is an incompatible change, but nobody depends on it already,
right?
WDYT? See patch attached.
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
