ahhhhhhhhhh
stupid stupid stupid :)
but why do this:
final String id = component != null ? component.getMarkupId() : null;
appendJavascript("Wicket.Focus.setFocusOnId('" + id + "');");
instead of
if (component != null)
appendJavascript("Wicket.Focus.setFocusOnId('" +
component.getMarkupId() + "');");
it doesn't really make sense to output with a null
and isn't a null component an error??
johan
On 5/8/07, Matej Knopp <[EMAIL PROTECTED]> wrote:
It was me. You code didn't allow null component, i needed to disable
setting focus, so i changed the code. But i didn't notice that i
always pass null to javascript ;-)
-Matej
On 5/8/07, Johan Compagner <[EMAIL PROTECTED]> wrote:
> only this time i think it was not you!
> It has to be me i think.. But how on earth that could pass me is beyond
me
> because i do use that code! and i have here servoy solutions where i
> demonstrated requestFocus!
>
> very very strange..
>
>
>
> On 5/8/07, Matej Knopp <[EMAIL PROTECTED]> wrote:
> >
> > has, it was just one my commit that has upset him. I'm pretty sure the
> > "stupid stupid stupid stupid was a message for me :)
> >
> > -Matej
> >
> > On 5/8/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> > > what will people think??? :)
> > >
> > > http://papernapkin.org/pastebin/view/5915
> > >
> > > -igor
> > >
> > >
> > > On 5/8/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> > > >
> > > > Author: jcompagner
> > > > Date: Tue May 8 07:44:07 2007
> > > > New Revision: 536209
> > > >
> > > > URL: http://svn.apache.org/viewvc?view=rev&rev=536209
> > > > Log:
> > > > stupid stupid stupid stupid....
> > > >
> > > > Modified:
> > > > incubator/wicket/trunk/jdk-1.4
> > > >
/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > >
> > > > Modified: incubator/wicket/trunk/jdk-1.4
> > > >
/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > URL:
> > > >
> >
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?view=diff&rev=536209&r1=536208&r2=536209
> > > >
> > > >
> >
==============================================================================
> > > > --- incubator/wicket/trunk/jdk-1.4
> > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > (original)
> > > > +++ incubator/wicket/trunk/jdk-1.4
> > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > Tue May 8 07:44:07 2007
> > > > @@ -403,7 +403,7 @@
> > > > +
> > > > component.toString());
> > > > }
> > > > final String id = component != null ?
> > > > component.getMarkupId() : null;
> > > > - appendJavascript("Wicket.Focus.setFocusOnId('" +
null
> > +
> > > > "');");
> > > > + appendJavascript("Wicket.Focus.setFocusOnId('" +
id +
> > > > "');");
> > > > }
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> >
>
