When you comment such a failing test, then at the very least add the
class and method to the issue. Otherwise it will be HELL to find the
test again. Also, ensure that the method is commented with the JIRA
issue number.

I agree that having dirty laundry for weeks gives a very bad smell,
but that doesn't mean the laundry should be thrown away or completely
hidden from sight.

Submitting a failing unit test is not only a way to get attention: I
can invest time to create unit tests that fail, but I can't always
solve the problem or have the time to solve it (creating a unit test
that fails for a particular bug is *HARD* and time consuming). So I
see it also as a way to contribute.

Also, please note that when we move to JDK 1.5, we can put this
discussion to rest, as we can annotate our tests to not run (JUnit
4.x). They will then be reported as skipped tests and not end up in
oblivion. TestNG is also a possibility, but I overheard that the maven
surefire plugin is not up to par.

Martijn

--
Join the wicket community at irc.freenode.net: ##wicket
Wicket 1.2.6 contains a very important fix. Download Wicket now!
http://wicketframework.org

Reply via email to