On 6/4/07, Johan Compagner <[EMAIL PROTECTED]> wrote:
it is harder now to specify converters on the session. (which we always had as far as i remember) because now you by pass that.
Well, it's one of these things that probably started with a good idea at some point in the past, but after a few refactorings was lost again. The only thing that was really session dependent was the instance of the locator, but it was actually created by the locator factory from the application settings. Furthermore, the relevant getConverter method in Session was final anyway, so it didn't do anything in terms of flexibility for people. And I'm glad it was final, otherwise the break would have been more nasty and I probably wouldn't have done this refactor. However, I was writing about custom converters for Wicket In Action this weekend, and I just couldn't live with the complexity of this feature. I think it is enough to have one level of indirection (the locator) and a factory for the locator doesn't do anything other than increase complexity. Now, with the changes, it is very simple to customize converters (override newConverterLocator in application) and the locator pattern is flexible for any use case you might think of, including session dependent ones of you would need that (though I'm pretty sure you don't). Eelco
