oh, this is in the new PageFactory code. also noticed a couple of javadoc complaints in eclipse.


looks like a nice place to put this abstraction though!  well done.

Jonathan Locke wrote:


don't know if i did this or not, but this:

/**
* Get the constructor for Class pageClas with the arguments given
* * @param pageClass
* @param arguments
* @return
*/
private final Constructor getConstructor(final Class pageClass, final Class[] arguments)
{
Constructor constructor = null;
if (arguments != null)
{
try
{
constructor = pageClass.getConstructor(arguments);
}
catch (NoSuchMethodException e)
{
; // ignore
}
}


looks kindof scary. shouldn't we throw a runtime exception here or at least log the problem?


------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop



-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop

Reply via email to