Bugs item #1209027, was opened at 2005-05-26 12:05
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1209027&group_id=119783
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: 1.0.0-rc3
Status: Open
Resolution: None
Priority: 7
Submitted By: Eelco Hillenius (eelco12)
Assigned to: Nobody/Anonymous (nobody)
Summary: The UploadForm class doesn't consider the encoding
Initial Comment:
This came in from the mailing list:
The UploadForm class doesn't consider the encoding of
request... Can anybody fix it???
this is the code snippet form Tapestry:
public void decode(HttpServletRequest request)
{
Map partMap = new HashMap();
request.setAttribute(PART_MAP_ATTRIBUTE_NAME,
partMap);
// The encoding that will be used to decode the
string parameters
// It should NOT be null at this point, but it
may be
// if the older Servlet API 2.2 is used
String encoding = request.getCharacterEncoding();
// DiskFileUpload is not quite threadsafe, so
we create a new instance
// for each request.
DiskFileUpload upload = new DiskFileUpload();
List parts = null;
try
{
if (encoding != null)
upload.setHeaderEncoding(encoding);
parts = upload.parseRequest(request,
_thresholdSize, _maxSize, _repositoryPath);
}
catch (FileUploadException ex)
{
throw new ApplicationRuntimeException(
Tapestry.format("DefaultMultipartDecoder.unable-to-decode",
ex.getMessage()),
ex);
}
int count = Tapestry.size(parts);
for (int i = 0; i < count; i++)
{
FileItem uploadItem = (FileItem) parts.get(i);
if (uploadItem.isFormField())
{
try
{
String name =
uploadItem.getFieldName();
String value;
if (encoding == null)
value = uploadItem.getString();
else
value =
uploadItem.getString(encoding);
ValuePart valuePart = (ValuePart)
partMap.get(name);
if (valuePart != null)
{
valuePart.add(value);
}
else
{
valuePart = new ValuePart(value);
partMap.put(name, valuePart);
}
}
catch (UnsupportedEncodingException ex)
{
throw new ApplicationRuntimeException(
Tapestry.format("illegal-encoding", encoding),
ex);
}
}
else
{
UploadPart uploadPart = new
UploadPart(uploadItem);
partMap.put(uploadItem.getFieldName(),
uploadPart);
}
}
}
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1209027&group_id=119783
-------------------------------------------------------
SF.Net email is sponsored by: GoToMeeting - the easiest way to collaborate
online with coworkers and clients while avoiding the high cost of travel and
communications. There is no equipment to buy and you can meet as often as
you want. Try it free.http://ads.osdn.com/?ad_id=7402&alloc_id=16135&op=click
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
