This is more of a stylistic point. I would like to be able to put my main form processing logic (the usual case) into form's handler while keeping my special cases in the buttons. Also, for me, it is more natural to think that the button's onsubmit() "overrides" the form's onsubmit.
-----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Phil Kulak Sent: Tuesday, July 05, 2005 10:04 AM To: [email protected] Subject: Re: [Wicket-develop] [ wicket-Bugs-1220639 ] form processing could be better defined Well, if you know that any form onSubmit is going to be called before your button, I don't see the problem. I tend to either put the submit logic in the button(s) or the form, not both. Why would you need to do both? On 7/5/05, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > The only problem with that is that validate() calls onSubmit() in the > form, the button's onsubmit() should get the priority and control over > the form's onsubmit(). > > > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Phil > Kulak > Sent: Tuesday, July 05, 2005 9:05 AM > To: [email protected] > Subject: Re: [Wicket-develop] [ wicket-Bugs-1220639 ] form processing > could be better defined > > haha, that's almost exactly what I was thinking. I actually added a > method to button called "validatesForm". It seems to work well with > this > onValidate() method: > > protected void onValidate() > { > final Button button = findSubmittingButton(); > if (button == null) > { > validate(); > } > else > { > if (button.validatesForm()) > { > if (validate()) > { > button.onSubmit(); > } > } > else > { > button.onSubmit(); > } > } > } > > On 7/5/05, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > > When do you guys think this will be semi-finished in HEAD? > > > > Here is the functionality im looking for: > > I would like to be able to specify whether or not the form should > > validate based on the submitting button and to have the button's > > onsubmit handler called before the forms onsubmit handler. > > > > For example: > > Button can have a boolean validateForm() and a boolean onSubmit(), > > if false is returned from the button's onSubmit() the form's > > onSubmit() doesn't get called. > > > > My usecase is a wizard. When the user presses the back button in the > > wizard I would like to record the user's input and go back a step > > w/o validation and onsubmit() being called. > > > > If this is on par with what you guys had in mind I would be happy to > > submit a patch. > > > > Thanks, > > Igor > > > > > > > > -----Original Message----- > > From: [EMAIL PROTECTED] > > [mailto:[EMAIL PROTECTED] On Behalf Of > > SourceForge.net > > Sent: Tuesday, June 14, 2005 11:27 AM > > To: [EMAIL PROTECTED] > > Subject: [Wicket-develop] [ wicket-Bugs-1220639 ] form processing > > could be better defined > > > > Bugs item #1220639, was opened at 2005-06-14 20:27 Message generated > > for change (Tracker Item Submitted) made by Item Submitter You can > > respond by > > visiting: > > https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1220639 > > &g > > roup_i > > d=119783 > > > > Please note that this message will contain a full copy of the > > comment thread, including the initial issue submission, for this > > request, not just the latest update. > > Category: core > > Group: None > > Status: Open > > Resolution: None > > Priority: 5 > > Submitted By: Eelco Hillenius (eelco12) Assigned to: > > Nobody/Anonymous > > (nobody) > > Summary: form processing could be better defined > > > > Initial Comment: > > The JavaDoc for From says that a form with multiple buttons will not > > automatically validate itself, but if you look at Form.onValidate(), > > it's clear that every form will always be automatically valildated. > > > > Imo, the form handler could be improved. I think we should have form > > level validation integrated as well (that's in head, though it is > > not finished > > yet) and the form handling process should be better defined, and it > > should be better possible to intercept/ break out of that process. > > > > -------------------------------------------------------------------- > > -- > > > > You can respond by visiting: > > https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1220639 > > &g > > roup_i > > d=119783 > > > > > > ------------------------------------------------------- > > SF.Net email is sponsored by: Discover Easy Linux Migration > > Strategies from IBM. Find simple to follow Roadmaps, straightforward > > articles, informative Webcasts and more! Get everything you need to > > get up to speed, > fast. > > http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click > > _______________________________________________ > > Wicket-develop mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > > > > > ------------------------------------------------------- > > SF.Net email is sponsored by: Discover Easy Linux Migration > > Strategies from IBM. Find simple to follow Roadmaps, straightforward > > articles, informative Webcasts and more! Get everything you need to > > get up to speed, fast. > > http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click > > _______________________________________________ > > Wicket-develop mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > ------------------------------------------------------- > SF.Net email is sponsored by: Discover Easy Linux Migration Strategies > from IBM. Find simple to follow Roadmaps, straightforward articles, > informative Webcasts and more! Get everything you need to get up to speed, fast. > http://ads.osdn.com/?ad_idt77&alloc_id492&op=ick > _______________________________________________ > Wicket-develop mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > ------------------------------------------------------- > SF.Net email is sponsored by: Discover Easy Linux Migration Strategies > from IBM. Find simple to follow Roadmaps, straightforward articles, > informative Webcasts and more! Get everything you need to get up to > speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id492&opclick > _______________________________________________ > Wicket-develop mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/wicket-develop > ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id492&op=ick _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id492&op=click _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
