you're right.  i realized that right after i sent the message... DOH! ;-)

i understand your problem now. it makes sense. how do you like the sort() method idea?

Igor Vaynberg wrote:

i don't exactly understand you problem, but if you're doing this to be efficient, couldn't you just leave the children alone, not recreate /anything/ and instead reorder the models referenced by the children by calling setModel?

Swapping the model isnt really safe...what if different hirarchies are built
depending on the model?

Basically the dataview needed to render components in the order they were
added because I cannot use the index-for-childid trick that listview uses
(because I don't have an index). So what I did was override add(), remove(),
removeAll() to add and remove ids from a list I keep, then I overrode the
rendering to use my list's iterator instead of markupcontainer.iterator() to
render the children.

If we make the ordering of iterator() a contract I can get rid of the above.

-Igor



Igor Vaynberg wrote:

If we don't guarantee the order I think we should at least introduce two template methods: onChildAdded(Component) and
onChildRemoved(Component).
These would be called from the add(), remove(), removeall(), etc.

Right now you need to look at the internals to know that autoadd() calls add() internally, removeAll() doesn't call remove() for
every object, etc.
Having onChildAdded and onChildRemoved will make it easy to add your own ordering logic.

Also making iterator() overridable will further facilitate a user-implemented ordering at render time, although this might open a can of worms.

-igor






-----Original Message-----
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Jonathan Locke
Sent: Monday, August 15, 2005 5:09 PM
To: [email protected]
Subject: Re: [Wicket-develop] [ wicket-Patches-1260172 ] add getchildren to markupcontainer


a good question. we should add it to the javadoc if it's true. i think we should at least guarantee that FormComponents are
validated
in the order they are added.
more than that, i'm not so sure.

Igor Vaynberg wrote:

On a side note,
Is the fact that iterator() now returns items in the order
they were
added going to be a formal contract?

-Igor





-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing
Projects & Teams *
Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing
Projects & Teams
* Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop





-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing
Projects & Teams *
Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop







-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop

Reply via email to