It is not really dead code ofcourse...
More dead comments :)
johan
On 1/17/06, Eelco Hillenius <
[EMAIL PROTECTED]> wrote:
Could you please check that Johan? And remove it if it is not needed anymore?
Eelco
On 1/17/06, Laurent PETIT <[EMAIL PROTECTED]> wrote:
> Yeah, it is dead code.
>
> It is part of the patch I suggested to Johan in order to have
> FormComponents keep the last user input (in order to allow re-display
> of user inputs even in cases of correct forms, when a roundtrip with
> the server is needed, as is the case with dependent drop down lists
> not using ajax, Immediate buttons ...)
>
>
> The initial FormComponent had a magic String value (something like
> "]--- NO INPUT ---[" to indicate that no user input was entered (thus
> differentiating a blank user input from the fact that the component
> still had not received any user input).
>
> I had proposed in my patch to have a boolean to keep the state,
> instead of the "magic value".
>
> But in order to save as much memory as possible, Jonathan kept the
> sort-of magic value and just commented out the initial boolean value.
>
> So for me it seems OK to delete this code.
>
> --
> Laurent
>
> On 1/17/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> > I just smelled something while looking at FormComponent:
> >
> > /**
> > * Indicates if the model is considered up to date with the last user input.
> > * If true, the model value will be used to render the component. If false,
> > * the rawInput value (last user input) will be used to render the
> > * component. (Can be false if validation fails, or if component not
> > * validated/updated after a user input, for example if a Button with
> > * defaultFormProcessing property set to true, aka "immediate button")
> > */
> > // private boolean modelUpToDate = true;
> >
> > why is there commented code in there? Please, the one that commented
> > it, remove it?
> >
> > EElco
> >
> >
> > -------------------------------------------------------
> > This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
> > for problems? Stop! Download the new AJAX search engine that makes
> > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
> > http://ads.osdn.com/?ad_idv37&alloc_id865&opclick
> > _______________________________________________
> > Wicket-develop mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/wicket-develop
> >
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
> for problems? Stop! Download the new AJAX search engine that makes
> searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
> http://sel.as-us.falkag.net/sel?cmdlnk&kid3432&bid#0486&dat1642
> _______________________________________________
> Wicket-develop mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/wicket-develop
>
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmdlnk&kid3432&bid#0486&dat1642
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
