[Wicket-develop] remove Page.checkAccess() in 1.2?

[Johan Compagner]

Hi,

Now we have a new Security build in in wicket (IAuthorizationStrategy) we don't really need Page.checkAccess() anymore
At least we think we don't need it anymore, we still need to check usecases.
For example i have access to the page at first, but i keep a reference to it. And i set it again as a response page some later time
then we still must go to the same easy check if i still have the rights to see that page or not.
(don't know currently how easy that is, maybe eelco can explain this)

But currently there is a problem how we handle checkAccess first it is not in the sync block as it should be.
Second it doesn't work quite right currently if the RequestTarget is and ListenerInterfaceRequestTarget because
that target gets a checkaccess but it does the checkAccess on the page where the event is being called on (in one step later)
(this was not the case in 1.1 the page was not checked again when a interface was called, this is a nice addition in 1.2 if you ask me)

But if that checks goes fine then we come in the process event and response phase. That process event is setting another page as the
response phase. And that page will be rendered now without any check.

So if we keep page.checkAccess() in 1.2 we need to rewrite that checkaccess step and fold it into the processEventsAndResponse step.
So that it is synced and check access is called on the right response page.

So what do we want? And is the new thing as easy to implement for the most things people are using it for (check for the user and redirect to a login page)

johan