Yes sorry. The reason why is was set to null is because when you call
Component.getStyle() you'll get = style + "_" + variation. At the
point in time we introduced variation we decided not to change every
occurence of getStyle() and replace it with getStyle() + "_" +
getVariation() but rather change the getStyle() implementation only.
Hence IMO ContainerInfo does work without your modification but it
doesnt harm either. And what applies to Component.getStyle() applies
to ContainerInfo.getStyle() as well; it contains the concatenated
style and variation info.
Juergen
---------- Forwarded message ----------
From: Eelco Hillenius <[EMAIL PROTECTED]>
Date: Mar 8, 2006 2:47 AM
Subject: [Wicket-autocvs] wicket/src/java/wicket/markup
ContainerInfo.java,1.1,1.2
To: [EMAIL PROTECTED]
Update of /cvsroot/wicket/wicket/src/java/wicket/markup
In directory
sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv20229/src/java/wicket/markup
Modified Files:
ContainerInfo.java
Log Message:
fix (?) we couldn't find whether setting variation (which isn't really
used yet, is it?) was deliberately set to null.
if it was shame on the guy that didn't document it.
Index: ContainerInfo.java
===================================================================
RCS file: /cvsroot/wicket/wicket/src/java/wicket/markup/ContainerInfo.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -d -r1.1 -r1.2
*** ContainerInfo.java 11 Dec 2005 19:49:11 -0000 1.1
--- ContainerInfo.java 8 Mar 2006 01:47:18 -0000 1.2
***************
*** 1,5 ****
/*
! * $Id$ $Revision:
! * 1.19 $ $Date$
*
*
==============================================================================
--- 1,5 ----
/*
! * $Id$
! * $Revision$ $Date$
*
*
==============================================================================
***************
*** 50,54 ****
this.locale = container.getLocale();
this.style = container.getStyle();
! this.variation = null;
this.fileExtension = container.getMarkupType();
}
--- 50,54 ----
this.locale = container.getLocale();
this.style = container.getStyle();
! this.variation = container.getVariation();
this.fileExtension = container.getMarkupType();
}
***************
*** 105,109 ****
public String toString()
{
! return containerClass.getName() + ":" + locale + ":" +
style + ":" + fileExtension;
}
}
--- 105,110 ----
public String toString()
{
! return "[" + containerClass.getName() + ",locale=" +
locale + ",style=" + style
! + ",variation=" + variation +
",extension=" + fileExtension + "]";
}
}
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Wicket-autocvs mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/wicket-autocvs
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
