-Igor
On 4/4/06,
Martijn Dashorst <[EMAIL PROTECTED]> wrote:
It would be more beneficial then to move it over to the next version, and have a collecting parameter instead of 15 parameters.
MartijnOn 4/4/06, Johan Compagner <[EMAIL PROTECTED]> wrote:this would mean a api break for resource locators
If we do it know we should specify some kind of nice wrapper for every param for this:
public interface IResourceStreamLocator
{
public IResourceStream locate(Class clazz, String path, String style, Locale locale,
String extension);
}
because we have to add there variation to it.
something like:
public interface IResourceStreamLocator
{
public IResourceStream locate(ResourceInfo);
}
?
johanOn 4/4/06, SourceForge.net <[EMAIL PROTECTED]> wrote:Bugs item #1463920, was opened at 2006-04-04 00:31
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1463920&group_id=119783
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: 1.3
Status: Open
Resolution: None
Priority: 5
Submitted By: Igor Vaynberg (ivaynberg)
Assigned to: Nobody/Anonymous (nobody)
Summary: fix style/variation mess
Initial Comment:
From: Igor Vaynberg
To: [email protected]
Date: Thu, 16 Mar 2006 20:32:55 -0700
Subject: Re: [Wicket-develop] Fwd: [Wicket-autocvs]
wicket/src/java/wicket/markup ContainerInfo.java,1.1,1.2
does anyone have time to clean this up before we go to rcs?
basically what i think is needed is to get rid of the
mess in Component that
concatenates style and variation together, and
introduce variation parameter
to IResourceStreamLocatorl.locate() just like style and
locale are there
now.
-Igor
On 3/7/06, Juergen Donnerstag <> wrote:
>
> Yes sorry. The reason why is was set to null is
because when you call
> Component.getStyle() you'll get = style + "_" +
variation. At the
> point in time we introduced variation we decided not
to change every
> occurence of getStyle() and replace it with
getStyle() + "_" +
> getVariation() but rather change the getStyle()
implementation only.
> Hence IMO ContainerInfo does work without your
modification but it
> doesnt harm either. And what applies to
Component.getStyle() applies
> to ContainerInfo.getStyle() as well; it contains the
concatenated
> style and variation info.
>
> Juergen
>
>
> ---------- Forwarded message ----------
> From: Eelco Hillenius <>
> Date: Mar 8, 2006 2:47 AM
> Subject: [Wicket-autocvs] wicket/src/java/wicket/markup
> ContainerInfo.java,1.1,1.2
> To: [EMAIL PROTECTED]
>
>
> Update of /cvsroot/wicket/wicket/src/java/wicket/markup
> In directory
>
sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv20229/src/java/wicket/markup
>
> Modified Files:
> ContainerInfo.java
> Log Message:
> fix (?) we couldn't find whether setting variation
(which isn't really
> used yet, is it?) was deliberately set to null.
> if it was shame on the guy that didn't document it.
>
> Index: ContainerInfo.java
>
===================================================================
> RCS file:
>
/cvsroot/wicket/wicket/src/java/wicket/markup/ContainerInfo.java,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -C2 -d -r1.1 -r1.2
> *** ContainerInfo.java 11 Dec 2005 19:49:11 -0000
1.1
> --- ContainerInfo.java 8 Mar 2006 01:47:18 -0000
1.2
> ***************
> *** 1,5 ****
> /*
> ! * $Id$ $Revision:
> ! * 1.19 $ $Date$
> *
> *
>
==============================================================================
> --- 1,5 ----
> /*
> ! * $Id$
> ! * $Revision$ $Date$
> *
> *
>
==============================================================================
> ***************
> *** 50,54 ****
> this.locale = container.getLocale();
> this.style = container.getStyle();
> ! this.variation = null;
> this.fileExtension =
container.getMarkupType();
> }
> --- 50,54 ----
> this.locale = container.getLocale();
> this.style = container.getStyle();
> ! this.variation =
container.getVariation();
> this.fileExtension =
container.getMarkupType();
> }
> ***************
> *** 105,109 ****
> public String toString()
> {
> ! return containerClass.getName() + ":"
+ locale + ":" +
> style + ":" + fileExtension;
> }
> }
> --- 105,110 ----
> public String toString()
> {
> ! return "[" + containerClass.getName()
+ ",locale=" +
> locale + ",style=" + style
> ! + ",variation=" +
variation +
> ",extension=" + fileExtension + "]";
> }
> }
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by xPML, a
groundbreaking scripting
> language
> that extends applications into web and mobile media.
Attend the live
> webcast
> and join the prime developer group breaking into this
new coding
> territory!
>
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> _______________________________________________
> Wicket-autocvs mailing list
> [EMAIL PROTECTED]
>
https://lists.sourceforge.net/lists/listinfo/wicket-autocvs
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by xPML, a
groundbreaking scripting
> language
> that extends applications into web and mobile media.
Attend the live
> webcast
> and join the prime developer group breaking into this
new coding
> territory!
>
http://sel.as-us.falkag.net/sel?cmdlnk&kid0944&bid$1720&dat1642
> _______________________________________________
> Wicket-develop mailing list
> [email protected]
>
https://lists.sourceforge.net/lists/listinfo/wicket-develop
>
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1463920&group_id=119783
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
--
Wicket 1.2 is coming! Write Ajax applications without touching _javascript_!
-- http://wicketframework.org
