Bugs item #1472451, was opened at 2006-04-18 18:32
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1472451&group_id=119783

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: 1.2
Status: Open
Resolution: None
Priority: 7
Submitted By: Eelco Hillenius (eelco12)
Assigned to: Nobody/Anonymous (nobody)
Summary: FormcomponentFeedbackBorder is broken in 1.2-rc1

Initial Comment:
> I use Wicket 1.2-rc1.
> I use FormComponentFeedbackBorder, but when input
error is occured, "*" is
> not output.
> How has meens been changed?

Hi,

I am trying Wicket for a few days now and wanted to use
FormComponentFeedbackBorder, too. I encountered the
same problem with
1.2beta3 and 1.2RC1. To reproduce the error, go to the
wicket-example/library EditPage and try to submit the
form with an empty
textfield for title. You get the feedback messages at
the top but no
asterisk next to the textfield.
It does work with wicket-examples-1.1.1.

When stepping through the code I recognized that
ContainerFeedbackMessageFilter#accept(FeedbackMessage)
fails and filters the
correct message out. So the FeedbackBorder never gets
any message.
The accept method calls the deprecated method
Component#isAncestorOf(Component) which calls
Component#getParent().contains(component, false) as the
@deprecated doc
states. I am really not familiar with wicket's
internals but that doesn't
make sense in my eyes. Calling
parent.getParent().contains(child, false)
returns true if child is a sibling of parent instead of
a child (which
isAncestorOf is standing for, isn't it?)

Perhaps parent.isAncestorOf(child) should be replaced with
parent.getParent().contains(child, true) which works
recursive (note the
true) or simply with parent.contains(child, false/true).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1472451&group_id=119783


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop

Reply via email to