I don't see why in PageMap.removeEntry:
public final void removeEntry(final IPageMapEntry entry)
{
// Remove entry from session
synchronized (session)
{
session.removeAttribute(attributeForId(entry.getNumericId()));
// Remove page from acccess stack
final Iterator stack = accessStack.iterator();
while (stack.hasNext())
{
final Access access = (Access)stack.next();
if (access.id == entry.getNumericId())
{
stack.remove();
}
}
// Let the session know we changed the pagemap
session.dirtyPageMap(this);
}
}
synchronization has to be done on the session. I'd like to sync on the
instance instead. Or can anyone see the catch?
Furthermore, the synchronized block that starts at line 95 of
DefaultRequestTargetResolverStrategy... is that necesarry, and if so,
wouldn't it be better to place after if
(requestParameters.isOnlyProcessIfPathActive()) ?
Eelco
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
