Agreed. Could you be more specific? I admit that my Eclipse config used spaces instead of tabs (which I think we agreed on), so I could be the offender in this case. I do usualy sort members on visibility etc... Can you tell us a few files that have that (I'm not a grep user, and I do not feel like learning it currently).

Btw. You have all commit rights, so if you're unhappy with formatting etc, pls go ahead and fix it. I know it's the responsibility of the one that made the errors in the first place, but so are those tons of Javadoc erros I fixed (and am still fixing) the last few months. Just works quicker if issues like that are fixed right away :)

Regards,

  Eelco

Jonathan Locke wrote:


i don't really care, just so long as it matches. my own style is indent under with curly braces but someone made a bunch of the code K&R style (you ought to be able to grep for that). i also sort members in idea/eclipse (one of them has this option) by visibility so that the public stuff is at the top and the most private implementation details are at the bottom. i don't care which style we pick as a group, but the code should all match! and the comments ought to wrap properly. whoever made these style changes should be responsible for making it all match. that's my two cents...


        jon

Johan Compagner wrote:



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop

Reply via email to