Jonathan Locke wrote:
actually, you can now do just Session.get() since i just made that public. i'm giving up on trying to stop access through threadlocals.
but everyone should be aware that you should only do this as a last resort! don't do it just because it's convenient. any component
will have a more efficient way to get either the Session or the RequestCycle.
I'll keep that in mind. Thanks for the warning.
Eelco
Johan Compagner wrote:
Already checked everything in.
We don't really need the session in those methods mayby only in 1% of the time but for those cases you can doe RequestCycle.get()
johan
Jonathan Locke wrote:
actually, i may have a different fix now that preserves the Session parameter by improving Component.getSession() so that it always works.
have you already checked this in? if not, please don't and i can check in my fix.
Eelco Hillenius wrote:
I am having problems with using detachable models in the constructor of components (and I do that often) as a result of the recent changes.
I propose (again) to remove the parameters alltogether, and thus have attach() and detach(). Either this, or - if you think performance will be a real problem here - the requestCycle parameter back again.
Eelco
------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
