All other frameworks (like swing) use isX for booleans this is very commonly used.
I don't care that much to vote against it but i just want to say this..
johan
Jonathan Locke wrote:
actually, i just tried this refactor in my local workspace and ALL the methods can be package private except get/isEnabled(). this breaks some of the tests, but that's no reason to leave the methods public since they're very confusing.
also, wanted to mention that isAddAttributeIfNotPresent should really be getAddAttributeIfNotPresent. it's only supposed to be isX() if it makes sense in english, like isVisible(), isEnabled(). one should not write isX() just because it returns a boolean. the getX() pattern for booleans is supported in bean introspection and should be used when the method name makes more sense this way.
jon
Jonathan Locke wrote:
also noticed that if this class was in the wicket package, replaceAttributeValue() could be package private... which would be good since nobody should ever call that method.
Jonathan Locke wrote:
i realize this is a fairly gratuitous change idea, but is there any value in the ComponentTag prefix on this class? it quickly becomes obvious in wicket that you can only modify component tags. so, wouldn't AttributeModifier be just as good and shorter to boot?
------------------------------------------------------- This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------- This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------- This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------- This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
