+1 Juergen
On Sat, 12 Feb 2005 20:22:36 +0100, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > +1 > > No problems renaming here. It's a pain for the people that are not > following this list/ are not upgrading regularily, but I suspect that's > not that many yet :). > > Eelco > > Martijn Dashorst wrote: > > > Yeah, > > > > But when you are already working with it... No turning back. If there > > is no 'real' project to work with a tool on, then you might as well > > not work on it (IMHO). Unless it is your baby, then one is allowed > > anything ;-) > > > > I'm not *that* sensitive to renames. But we gotta crank out 1.0 sooner > > rather than later. > > > > Martijn > > > > Jonathan Locke wrote: > > > >> > >> btw, i would suggest that anyone really sensitive to having their app > >> broken wait until 1.0 is released. > >> that should only be a matter of a couple/few weeks now... and there > >> may be more name changes still... > >> > >> Martijn Dashorst wrote: > >> > >>> +10000 > >>> > >>> :-) > >>> > >>> I'll wait with building a release until these renames have occurred. > >>> Otherwise people (like myself) are constantly renaming stuff in > >>> their applications... > >>> > >>> Martijn > >>> > >>> Jonathan Locke wrote: > >>> > >>>> > >>>> i also see some places where it ought to be onX() or handleX() > >>>> where it's neither, like selectionChanged()... > >>>> > >>>> converting everything to the onX() convention would be a little > >>>> annoying, but at least we'd finally be consistent throughout > >>>> and we do still have a couple more weeks probably before 1.0 > >>>> release (speaking of which, we ought to put out a new > >>>> beta soon... perhaps the last beta before RC1). > >>>> > >>>> for example, handleComponentTag ought to be onComponentTag, > >>>> handleValid() should be onValid(), selectionChanged > >>>> ought to be onSelectionChanged, etc... basically anywhere there's > >>>> an event method designed for overriding, it would > >>>> be onX(). > >>>> > >>>> Jonathan Locke wrote: > >>>> > >>>>> > >>>>> another thing to consider here is that we've been using handleX() > >>>>> instead of onX() most places in the toolkit. > >>>>> > >>>>> we ought to make this consistent one way or the other... > >>>>> > >>>>> Martijn Dashorst wrote: > >>>>> > >>>>>> When I am developing an application, I'm normally only interested > >>>>>> in valid submits or error submits. Not the 'advanced submit' > >>>>>> which occurs before validation. > >>>>>> > >>>>>> I find the name 'xxxValidSubmit' kind of not what I'm looking > >>>>>> for. Having onError and onSubmit should suffice. The > >>>>>> pre-validation submit shuold fall in the advanced section, and be > >>>>>> targeted as such. > >>>>>> > >>>>>> Having an onError which will be called when (one of) the > >>>>>> validators fail, should push most users into using the validators > >>>>>> and onError, instead of parsing the submitted values directly in > >>>>>> the onPreValidationSubmit(). > >>>>>> > >>>>>> Martijn > >>>>>> > >>>>>> Martijn > >>>>>> > >>>>>> Jonathan Locke wrote: > >>>>>> > >>>>>>> > >>>>>>> so, maybe: > >>>>>>> > >>>>>>> onSubmit() - IFormSubmitListener method > >>>>>>> onValidSubmit() - Form method called when valid form is submitted > >>>>>>> onError() - Form method called when validation errors occur > >>>>>>> > >>>>>>> ? > >>>>>>> > >>>>>>> of course this makes me want to rename the event handlers in > >>>>>>> ILinkListener, IOnChangeListener, IRedirectListener and > >>>>>>> IResourceListener... > >>>>>>> i'm good with the onX() pattern for events. should we make this > >>>>>>> more consistent like this? > >>>>>>> > >>>>>>> Jonathan Locke wrote: > >>>>>>> > >>>>>>>> > >>>>>>>> we could call it onValidSubmit() if you like, but onSubmit() is > >>>>>>>> asking for trouble because it's not formSubmitted(), which is > >>>>>>>> the onSubmit() handler (handles form submits, but not validated > >>>>>>>> form submits). if you want to handle all form submissions, > >>>>>>>> it's formSubmitted(). we could change that one to onSubmit() > >>>>>>>> except that none of the other IResourceRequestListener > >>>>>>>> subclasses use this pattern... > >>>>>>>> > >>>>>>>> Eelco Hillenius wrote: > >>>>>>>> > >>>>>>>>> I don't know... I like onSubmit etc (short and to the point, > >>>>>>>>> consistent with e.g. onLinkClicked). On the other hand, > >>>>>>>>> onLinkClicked will be called directly/ is the same as the > >>>>>>>>> interface method, but from handleXXX it is clear (at least to > >>>>>>>>> me) that Wicket did some processing after the interface method > >>>>>>>>> was called. > >>>>>>>>> > >>>>>>>>> Eelco > >>>>>>>>> > >>>>>>>>> Martijn Dashorst wrote: > >>>>>>>>> > >>>>>>>>>> If anything, the rename should have been to: > >>>>>>>>>> - onSubmit() > >>>>>>>>>> and create a new one if you want to differentiate an error > >>>>>>>>>> condition: > >>>>>>>>>> - onError() > >>>>>>>>>> > >>>>>>>>>> This is more consistent with the rest of Wicket: event > >>>>>>>>>> handlers begin always with 'on'. > >>>>>>>>>> > >>>>>>>>>> Martijn > >>>>>>>>>> > >>>>>>>>>> Martijn Dashorst wrote: > >>>>>>>>>> > >>>>>>>>>>> Hi, > >>>>>>>>>>> > >>>>>>>>>>> I was checkout out HEAD and encountered numerous compilation > >>>>>>>>>>> problems due to this rename. Why was this done? > >>>>>>>>>>> > >>>>>>>>>>> Martijn > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> ------------------------------------------------------- > >>>>>>>>>> SF email is sponsored by - The IT Product Guide > >>>>>>>>>> Read honest & candid reviews on hundreds of IT Products from > >>>>>>>>>> real users. > >>>>>>>>>> Discover which products truly live up to the hype. Start > >>>>>>>>>> reading now. > >>>>>>>>>> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > >>>>>>>>>> _______________________________________________ > >>>>>>>>>> Wicket-develop mailing list > >>>>>>>>>> [email protected] > >>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/wicket-develop > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> ------------------------------------------------------- > >>>>>>>>> SF email is sponsored by - The IT Product Guide > >>>>>>>>> Read honest & candid reviews on hundreds of IT Products from > >>>>>>>>> real users. > >>>>>>>>> Discover which products truly live up to the hype. Start > >>>>>>>>> reading now. > >>>>>>>>> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > >>>>>>>>> _______________________________________________ > >>>>>>>>> Wicket-develop mailing list > >>>>>>>>> [email protected] > >>>>>>>>> https://lists.sourceforge.net/lists/listinfo/wicket-develop > >>>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> ------------------------------------------------------- > >>>>>>>> SF email is sponsored by - The IT Product Guide > >>>>>>>> Read honest & candid reviews on hundreds of IT Products from > >>>>>>>> real users. > >>>>>>>> Discover which products truly live up to the hype. Start > >>>>>>>> reading now. > >>>>>>>> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > >>>>>>>> _______________________________________________ > >>>>>>>> Wicket-develop mailing list > >>>>>>>> [email protected] > >>>>>>>> https://lists.sourceforge.net/lists/listinfo/wicket-develop > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> ------------------------------------------------------- > >>>>>>> SF email is sponsored by - The IT Product Guide > >>>>>>> Read honest & candid reviews on hundreds of IT Products from > >>>>>>> real users. > >>>>>>> Discover which products truly live up to the hype. Start reading > >>>>>>> now. > >>>>>>> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > >>>>>>> _______________________________________________ > >>>>>>> Wicket-develop mailing list > >>>>>>> [email protected] > >>>>>>> https://lists.sourceforge.net/lists/listinfo/wicket-develop > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> ------------------------------------------------------- > >>>>>> SF email is sponsored by - The IT Product Guide > >>>>>> Read honest & candid reviews on hundreds of IT Products from real > >>>>>> users. > >>>>>> Discover which products truly live up to the hype. Start reading > >>>>>> now. > >>>>>> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > >>>>>> _______________________________________________ > >>>>>> Wicket-develop mailing list > >>>>>> [email protected] > >>>>>> https://lists.sourceforge.net/lists/listinfo/wicket-develop > >>>>>> > >>>>> > >>>>> > >>>>> ------------------------------------------------------- > >>>>> SF email is sponsored by - The IT Product Guide > >>>>> Read honest & candid reviews on hundreds of IT Products from real > >>>>> users. > >>>>> Discover which products truly live up to the hype. Start reading now. > >>>>> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > >>>>> _______________________________________________ > >>>>> Wicket-develop mailing list > >>>>> [email protected] > >>>>> https://lists.sourceforge.net/lists/listinfo/wicket-develop > >>>>> > >>>> > >>>> > >>>> ------------------------------------------------------- > >>>> SF email is sponsored by - The IT Product Guide > >>>> Read honest & candid reviews on hundreds of IT Products from real > >>>> users. > >>>> Discover which products truly live up to the hype. Start reading now. > >>>> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > >>>> _______________________________________________ > >>>> Wicket-develop mailing list > >>>> [email protected] > >>>> https://lists.sourceforge.net/lists/listinfo/wicket-develop > >>>> > >>> > >>> > >>> > >>> ------------------------------------------------------- > >>> SF email is sponsored by - The IT Product Guide > >>> Read honest & candid reviews on hundreds of IT Products from real > >>> users. > >>> Discover which products truly live up to the hype. Start reading now. > >>> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > >>> _______________________________________________ > >>> Wicket-develop mailing list > >>> [email protected] > >>> https://lists.sourceforge.net/lists/listinfo/wicket-develop > >>> > >> > >> > >> ------------------------------------------------------- > >> SF email is sponsored by - The IT Product Guide > >> Read honest & candid reviews on hundreds of IT Products from real users. > >> Discover which products truly live up to the hype. Start reading now. > >> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > >> _______________________________________________ > >> Wicket-develop mailing list > >> [email protected] > >> https://lists.sourceforge.net/lists/listinfo/wicket-develop > >> > > > > > > > > ------------------------------------------------------- > > SF email is sponsored by - The IT Product Guide > > Read honest & candid reviews on hundreds of IT Products from real users. > > Discover which products truly live up to the hype. Start reading now. > > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > > _______________________________________________ > > Wicket-develop mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > _______________________________________________ > Wicket-develop mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/wicket-develop > ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
