I'm for b also.
Jonathan Locke wrote:
+1
i'm for b.
i think it should be code reviewed, but i'd vote for groovy class resolver.
would like to see more work done on a hibernate abstraction before it is a wicket-extension. in fact, i think that is a whole project of its own. the code in contrib as it is looks useful, but i'm sceptical that it's ready to be a public wicket api for all time and i'd at least like to give us a chance to code review and critique it. i'd recommend waiting for 1.1.
Well, if there's any part of contrib that has a lot of testing hours, it is the Hibernate stuff, which is used in all Topicus projects so far. It might be you don't like the API, but it is stable as hell and immediately usefull.
would like to see a little more work done on ValidationAttrib*, but mostly minor stuff i think. the doc comment should give an example of how it's used. Attib is typoed and should be Attribute anyway since we don't generally abbreviate stuff like this in wicket. getPostFix should be getSuffix. postfix is a mathematics thing. also this class deals with css stuff which isn't done. i'd recommend waiting for 1.1. same goes for Required* and DataTextField.
There's not much going on in these things. The Validation stuff could use a review, but I see no point in waiting for 1.1. Otherwise, we'll put it in the 'real' contrib, I'm fine with that.
fvalidate is abbreviated in a wierd way and claims to do javascript validation, which is something we're probably not releasing in 1.0. i'd like us to wait on such features for 1.1.
fValidate could go to the 'real' contrib as well, as it is too specific to be in the pollished components section.
fvalidate is the name of the library it uses: fvalidate (http://www.peterbailey.net/fValidate/). fValidate is probably the most used javascript validation lib at moment in Java webapp land. At least WebWorks (I think still #2 of the model 2 frameworks) integrated it, but there might be more. fvalidate also has been discussed in weblogs like Matt Raible's.
What is good about the fvalidation stuff is that it works, now! In the absence of anything else that proves Wicket can handle these kind of things, I think it is good to have it. At the very least, it gives people an example of how Javascript validation *could* be done with Wicket. It was never my goal to make this the default way of Javascript validation though. Personally, I'm not interested in Javascript validation at all, but felt it was/ is a real short comming of any webframework that is not able to support it.
The only things that has to be done to finish it, is to expand the example a bit, build in some date specific stuff, and - when the CSS/ Javascript integration for Wicket is ready, pre-package the javascript and css files. Besides that, it works good, and fvalidation is a neat, configurable lib.
So, +1 for moving it, -1 for deleting it.
Eelco
Martijn Dashorst wrote:
+1 for extensions...
What is the next procedure?
[ ] a. rename wicket-contrib to wicket-extensions?
[ ] b. vote for each component in wicket-contrib to be moved into wicket-extensions?
I'm for a.
Martijn
Johan Compagner wrote:
yes with those names then also +1 for extentions
Juergen Donnerstag wrote:
+1 for wicket-extensions
Juergen
On Sun, 13 Feb 2005 10:47:50 +0000, Chris Turner <[EMAIL PROTECTED]> wrote:
I agree that wicket-components is too restrictive a name. I certainly agree with having a new module holding polished additional functionality. Some other suggestions for names:
wicket-extras wicket-addons wicket-extensions wicket-additions
I personally like wicket-extensions - classes and components that extend
the wicket core. That way we are keeping it very open as to what this
module can contain but we are making it very clear that these are things
closely related to wicket.
regards, Chris
Eelco Hillenius wrote:
Though I like wicket-components better than wicket-library, I think components would be too narrow. One of the really usefull things in contrib currently is PagedList for the efficient backing of PagedListView. But that's not a component, so it would seem out of place in wicket-components.
So, I guess I go for wicket-library.
Eelco
Jonathan Locke wrote:
so, it seems like we agree there should be a repository for polished,
supported components that aren't basic enough to be part of the
core. this sounds like a great way to trim down the core a bit and
keep it focused. however, i really dislike the "contrib" name for
this, as i've said. based on experience with other projects this
tends to indicate a project that is a kind of dumping ground for
whatever anyone contributes. anyway, i'd be fine with calling this
something else like "wicket-components" or "wicket-library" or
whatever we agree on. what do people think it should be called?
once we agree on a name, we can start moving things into this project
from the core and contrib. i think a good policy would be to vote on
things that go into this polished component library and hopefully
code review them as a group well (as time permits).
thoughts?
jon
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
