> 
> seems like last-mod time should be construction time of the object, not
> null.

it is null, because the watcher implementation checks that value. If
it is null, if will tell you that this resource can not be watched
(like jar entries).

> 
> also, since wicket.util is generic, it seems like this:
> 
>         this(string, "text/html");
> 
> should be
> 
>         this(string, "text");
> 

Im not sure. it seems not be treated consistently currenlty. 

from IResource
         * @return The mime type of this resource, such as "image/jpeg" or
         *         "text/html"
from File/UrlResource
         * @return The extension of this resource, such as "jpeg" or "html"
from URLConnection.getFileNameMap().getContentTypeFor()
        Gets the MIME type for the specified file name. 
and this is how we use it
                response.setContentType(resource.getContentType());

so it really should be the MIME type.

> and usages that care about the subtype html should use the two arg
> constructor.

yes, ok understood.

> 
> i suppose i might be a little purist though, so i didn't make the
> change.  up to you, juergen!  ;-)
> 
> okay, i keep getting distracted by wicket... i gotta get back to my
> other stuff!! ;-)
> 
>          jon
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> Wicket-develop mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/wicket-develop
>


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop

Reply via email to