Good idea. You want to file it?
Cheers,
Eelco
*Conclusions*
Overall I think the performance of Wicket was fairly sound. There were no obvious bottlenecks in the main processing code. Generating images is always going to be costly, but this is only a one-off hit for applications like hangman. However, I would make the following two recommendations:
1) We look at the code that moves content from a stream for a resource into the response stream and see if we can improve the performance of this in any way as a fairly significant amount of processing time is being spent in this area. This would certainly speed up applications like hangman or Gili's application which are heavy users of resources.
2) We revisit everywhere where calls are made to String.replaceAll() and implement our own more efficient version that works on raw character data and doesn't rely on regexp pattern generation and so on. Far too much time is being spent doing regexp pattern creation and matching for what are essentially very simple replacements. For Hangman, the obvious candidates are:
wicket.markup.html.image.resource.LocalizedImageResource.setSrcAttribute(ComponentTag) - line 270
wicket.markup.parser.XmlTag.toXmlString(String) - line 545
wicket.markup.html.link.Link.onComponentTag(ComponentTag) - line 352
Regards, Chris
------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
