the problem seems to be that the new replaceAll does not replace \n,
\r and \t like they used to in HtmlDocumentParser.<init>.
yes, the problem is with
public HtmlDocumentParser(final String document)
{
this.document = Strings.replaceAll(document, "\n", "");
this.document = Strings.replaceAll(document, "\r", "");
this.document = Strings.replaceAll(document, "\t", " ");
}
what is wrong with that? remember that document is != this.document.
Though you replace tthe string, you always do it on the original one
and not on the one already changed. I commtted the following change.
public HtmlDocumentParser(final String document)
{
this.document = document;
this.document = Strings.replaceAll(this.document, "\n", "");
this.document = Strings.replaceAll(this.document, "\r", "");
this.document = Strings.replaceAll(this.document, "\t", " ");
And may I kind ask you to validate your eclipse settings. Comparing
you check-ins is with previous mails is aweful, as the whole file
seems to have changed which is probably due to spaces, tabs etc..
Though I wonder how this can happen. I thought we have an eclipse
confige file to take of these agreed-upon "standards".
Juergen
On Apr 7, 2005 12:29 AM, Johan Compagner <[EMAIL PROTECTED]> wrote:
i have currently no idea how this can be related to the things that are
changed today (at least what i did see)
what goes wrong is this:
HtmlDocumentParser.processDirective()
{
String part = document.substring(pos);
if (part.matches("<!--.*-->.*"))
{
and this if should match so that it returns the COMMENT tag.
The input is the file below.
It seems that the .* (and then especially the . ) doesn't match when it
encounters a \r or \n
If i make replace it first:
String part = document.substring(pos).replace('\n',' ').replace('\r',' ');
then it works.. But i am not an expert in regexp so i don't know what would
handle (or ignore) everything between 2 patterns
<!--
$Id: AttributeModifierComponentPage.html,v 1.3
2005/03/17 22:27:20 jdonnerstag Exp $
$Revision: 1.3 $
$Date: 2005/03/17 22:27:20 $
====================================================================
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<html>
<head>
<title>Attribute Modifier Test Page</title>
</head>
<body>
<span class="label" wicket:id="label1">Label 1</span>
<span class="overrideLabel" wicket:id="label2">Label 2</span>
<span class="insertLabel" wicket:id="label3">Label 3</span>
</body>
</html>
Juergen Donnerstag wrote:
it can only be one of latest changes from today, as I build a new
version not too long ago this evening.
Juergen
On Apr 6, 2005 11:02 PM, Johan Compagner <[EMAIL PROTECTED]> wrote:
Hi,
I get some test errrors when building wicket
most of them are all the same:
ERROR - HtmlDocumentParser - Unexpected markup found: <!--,
$Id: WicketPanelPage...
It seems that the html validator doesn't see that it is a comment token
when it sees <!-- XXXXX -->
does somebody knows why this is or should i dig deeper?
johan
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
