I didn't notice it before, but there are some convenience methods in ListView for editing (move, delete) list elements. One of the commentors on Matt Raible's blog pointed out: 'and the list page, if you remove one book, and click back , and then click that remove again, it will remove other book'.

The problem is - like we discussed earlier at our meeting in Deventer - that you can't depend on the ListItem component, but that you should use the actual object, like in this case the id of the book to remove.

I think providing such links in the ListView class is not a good idea anyway. It is not part of what a list is, and it 'hides' complexity which it shouldn't hide. It's much better to have users make a remove links and such explicitly, so that users have to think about what they're doing. And it is not much code anyway.

So, I propose:
- remove methods removeLink and moveUp/DownLink;
- fix the library example and anything that uses these links.

Votes please?

Eelco


------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop

Reply via email to