Jon and I suggest going forward with RC2 and postpone this discussion to RC3 or possibly post 1.0 (depending on the solution).
Martijn Eelco Hillenius wrote: > It was late yestday, and I didn't feel like thinking anymore I guess ;) > > Yes, the problem is that the pageable list view component is one of > the few components that is not immutable in the sense that the page > number - a component property - changes. This page number naturally is > not rolled back with an undo. > > So, I think the conclusion here is that there are cases that - besides > the model - part of the component state should be recorded as well. > That's kind of what you mean, right? > > Jonathan, what do you think of that? > > Eelco > > > Johan Compagner wrote: > >> You are talking about this comment i take: >> >> "Problem was that modelChanging and modelChanged were never called. >> Using the back button on the library example can still lead to funny >> behaviour (e.g. try navigating to page 3, delete a book, then use the >> back button to go to page 1, and delete an item there... you'll end >> up at page 3 again), but I guess that's just fine for the moment." >> >> So the pageablelistview has an page index (3) and then you go back do >> something on page 1 but then the listview is rendered again with the >> page index == 3... >> So in the end.. a change of the page index is a data change that >> should be recorded that way... >> Only thing is that this index is kept inside PageableListView i see. >> So it is not a model thing that can be recorded... >> >> Maybe components should be able to say: i want to record this >> property::value for the current version... >> And then they will get that back with a method on >> component.setVersionPropertyValue(String property, Object value) >> >> This would be nice anyway i think because now a model copy is not >> that cheap. But if i could add simple things myself in >> the version manager then i can control what should be kept and keep >> it as clean/light as possible. >> >> johan >> >> >> >> Eelco Hillenius wrote: >> >>> Fixed, though I'd appreciate it if Jonathan and Johan could give the >>> library example a closer look. Especially the comment I made on the >>> bug/ commit... any idea's how we could improve that? >>> >>> Cheers, >>> >>> Eelco >>> >>> >>> Eelco Hillenius wrote: >>> >>>> http://sourceforge.net/tracker/index.php?func=detail&aid=1183947&group_id=119783&atid=684975 >>>> should be fixed first. >>>> >>>> Eelco >>>> >>>> >>>> Martijn Dashorst wrote: >>>> >>>>> All, >>>>> >>>>> Is Wicket ready to be shipped in 1.0-RC2? Or are there things left to >>>>> do/open? >>>>> >>>>> 1183529 library example not multiuser >>>>> <http://sourceforge.net/tracker/index.php?func=detail&aid=1183529&group_id=119783&atid=684975> >>>>> >>>>> 1181844 ResourceTest fails in CVS HEAD >>>>> <http://sourceforge.net/tracker/index.php?func=detail&aid=1181844&group_id=119783&atid=684975> >>>>> >>>>> 1178309 tree versions on selection >>>>> <http://sourceforge.net/tracker/index.php?func=detail&aid=1178309&group_id=119783&atid=684975> >>>>> >>>>> 1174932 Clustering problem with linkomatic >>>>> <http://sourceforge.net/tracker/index.php?func=detail&aid=1174932&group_id=119783&atid=684975> >>>>> >>>>> 1166884 Model data is lost when using a paginated list within a form >>>>> <http://sourceforge.net/tracker/index.php?func=detail&aid=1166884&group_id=119783&atid=684975> >>>>> >>>>> 1152539 straighten out our page destination story >>>>> <http://sourceforge.net/tracker/index.php?func=detail&aid=1152539&group_id=119783&atid=684975> >>>>> >>>>> 1117495 create workable user's guide >>>>> <http://sourceforge.net/tracker/index.php?func=detail&aid=1117495&group_id=119783&atid=684975> >>>>> >>>>> >>>>> The user's guide is a work in progress. So I gather that one does not >>>>> need resolving this weekend. >>>>> Any others having high priority? >>>>> >>>>> Martijn >>>>> >>>>> >>>>> ------------------------------------------------------- >>>>> SF email is sponsored by - The IT Product Guide >>>>> Read honest & candid reviews on hundreds of IT Products from real >>>>> users. >>>>> Discover which products truly live up to the hype. Start reading now. >>>>> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click >>>>> _______________________________________________ >>>>> Wicket-develop mailing list >>>>> [email protected] >>>>> https://lists.sourceforge.net/lists/listinfo/wicket-develop >>>>> >>>>> >>>> >>>> >>>> >>>> ------------------------------------------------------- >>>> SF email is sponsored by - The IT Product Guide >>>> Read honest & candid reviews on hundreds of IT Products from real >>>> users. >>>> Discover which products truly live up to the hype. Start reading now. >>>> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click >>>> _______________________________________________ >>>> Wicket-develop mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/wicket-develop >>> >>> >>> >>> >>> >>> >>> >>> ------------------------------------------------------- >>> SF email is sponsored by - The IT Product Guide >>> Read honest & candid reviews on hundreds of IT Products from real >>> users. >>> Discover which products truly live up to the hype. Start reading now. >>> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click >>> _______________________________________________ >>> Wicket-develop mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/wicket-develop >>> >> >> >> ------------------------------------------------------- >> SF email is sponsored by - The IT Product Guide >> Read honest & candid reviews on hundreds of IT Products from real users. >> Discover which products truly live up to the hype. Start reading now. >> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click >> _______________________________________________ >> Wicket-develop mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > _______________________________________________ > Wicket-develop mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/wicket-develop > ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
